Perspective rendering has recently regressed quite a lot
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: emilio, Assigned: kvark)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
All the the demos from bug 1504590 / bug 1505222 / etc have regressed on Nightly (before my patches too, heh :P).
Textures are deformed and what not, looks pretty bad. Will run mozregression ASAP.
|
Reporter | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
|
Reporter | |
Comment 2•6 years ago
|
||
|
Assignee | |
Comment 4•6 years ago
|
||
Perspective quality issues regressions with plane splitting should be addressed by https://phabricator.services.mozilla.com/D17854
|
|
Assignee | |
Comment 5•6 years ago
|
||
Actually, there are still issues with those (i.e. the change addresses some things but not the others), not sure which ones are regressions and which aren't.
|
|
Assignee | |
Comment 6•6 years ago
|
||
Clamp the UV interpolated from image quad corners in the
plane-splitting shader. In some cases, the values produced by Rust side
are outside of the target range. Coupled with the fact that Rust side
doesn't properly do near-plane splitting when evaluating those, it's
reasonable for the shader to do a little cleanup before using them.
|
||
Updated•6 years ago
|
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Updated•6 years ago
|
|
|
Reporter | |
Comment 10•6 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)
You rock Dzmytri :)
Err, I got the spelling wrong, but you still rock :)
|
|
Assignee | |
Comment 11•6 years ago
|
||
Thanks Emilio!
If you haven't already created a bug specifically for local space scaling, let's make one. It would be very useful to have.
Description
•