Closed
Bug 1521743
Opened 6 years ago
Closed 6 years ago
Source and type label for CardGrid component
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
People
(Reporter: andreio, Assigned: gsuntop)
References
Details
(Keywords: github-merged)
Attachments
(4 files)
The bottom label / text [see attachment] of the card does not match the current spec.
Reporter | ||
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Assignee: nobody → gsuntop
Iteration: --- → 66.4 - Jan 21 - 27
Updated•6 years ago
|
Priority: -- → P1
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
To test:
- Any layout with a hero unit would do, example:
{"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
- Load a new tab and ensure hero cards don't say "TODO: SOURCE" but instead say the source.
Updated•6 years ago
|
Keywords: github-merged
Updated•6 years ago
|
status-geckoview66:
--- → fixed
Comment 4•6 years ago
|
||
This landed in https://github.com/mozilla/activity-stream/commit/672e9c01abfd182e3a67af37dedcaa3dd2708beb but did not have the bug number in the commit message.
"using domain for article sources (#4717)"
Exported in bug 1522752 https://hg.mozilla.org/mozilla-central/rev/9d660bf33923
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 5•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-01-31)
OS : Mac and Windows 10 Pro
Results attached QA Results : bug - 1521743.png
Seeing the actual source.
Closing as verified.
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•