Closed Bug 1521860 Opened 6 years ago Closed 6 years ago

Ensure we don't use object spread syntax with data from server

Categories

(Firefox :: New Tab Page, enhancement, P2)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: thecount, Assigned: andreio)

References

Details

(Keywords: github-merged)

I can see one spot where we do this in the List component. Maybe others.

Assignee: nobody → khudson
Iteration: --- → 66.4 - Jan 21 - 27
Priority: -- → P1
Assignee: khudson → nobody
Priority: P1 → P2
Assignee: nobody → andrei.br92
Summary: Ensure we don't use object destructuring for components on server returned values → Ensure we don't use object spread syntax with data from server
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ad01e12992b5b2227fd93f99ab8e43dcb3eec715
Bug 1521860 - Ensure we don't use object spread syntax with data from server
Blocks: 1523023

https://hg.mozilla.org/mozilla-central/rev/4fb9d276e063

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

I checked with Andrei and he said "no QA needed for this bug".

Marking as verified.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.