Closed
Bug 1522138
Opened 6 years ago
Closed 6 years ago
Update Debugger Frontend v120
Categories
(DevTools :: Debugger, enhancement, P2)
DevTools
Debugger
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Firefox 66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file)
(deleted),
patch
|
davidwalsh
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a2d198f09c2fda60591e8712699b4c59bb58ea
posting this now so that we can continue keeping the releases going even if we're not going to land them yet...
Assignee | ||
Comment 2•6 years ago
|
||
Assignee: nobody → jlaster
Attachment #9038912 -
Flags: review?(dwalsh)
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 4•6 years ago
|
||
Comment on attachment 9038912 [details] [diff] [review]
120-1.patch
- Arrows look good
- Refresh looks good
- Memoizing working
- Log points working
Attachment #9038912 -
Flags: review?(dwalsh) → review+
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d05ea5ad7945
[release 120] [Breakpoint] fix selectBreakpoint (#7756). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/10b38250b65e
[release 120] put log points behind a flag (#7761). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/38d9045b04e6
[release 120] [Preview] Ensure correct event listening (#7778). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c105118de1
[release 120] [performance] Memoize breakpoints and URL parsing (#7774). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2913cb9cb20
[release 120] Show proper icon for watch expression refresh (#7791). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e402395db6c
[release 120] Fix color of arrows in trees (#7790). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfc7aa2486d4
[release 120] Update debugger frontend. r=dwalsh
Assignee | ||
Comment 6•6 years ago
|
||
I think it is worth it to land these 7 commits despite the soft freeze for a couple of reasons
- Fix color of arrows in trees (#7790). r=dwalsh
- Show proper icon for watch expression refresh (#7791). r=dwalsh
- [performance] Memoize breakpoints and URL parsing (#7774). r=dwalsh
- [Preview] Ensure correct event listening (#7778). r=dwalsh
- put log points behind a flag (#7761). r=dwalsh
- [Breakpoint] fix selectBreakpoint (#7756). r=dwalsh
- the fixes are each small (style, ui regresion)
- they all have a significant user impact
- they are relatively small risk
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d05ea5ad7945
https://hg.mozilla.org/mozilla-central/rev/10b38250b65e
https://hg.mozilla.org/mozilla-central/rev/38d9045b04e6
https://hg.mozilla.org/mozilla-central/rev/c4c105118de1
https://hg.mozilla.org/mozilla-central/rev/c2913cb9cb20
https://hg.mozilla.org/mozilla-central/rev/0e402395db6c
https://hg.mozilla.org/mozilla-central/rev/cfc7aa2486d4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•