Closed
Bug 1522233
Opened 6 years ago
Closed 6 years ago
Style HR component
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: k88hudson, Assigned: k88hudson)
References
Details
(Keywords: github-merged)
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Test steps:
- Set
browser.newtabpage.activity-stream.discoverystream.config
pref to:{"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
- Check to make sure the horizontal line under the "Best of the Web" heading at the top is a light grey colour and 1px high.
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/c90f6688c6096774799d28635502f6e7066fa621
Bug 1522233 - Add styling for HorizonalRule and Hero borders
Assignee | ||
Updated•6 years ago
|
Keywords: github-merged
Comment 4•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/5ba3d8cfe5021c71f343f487fdf401018c2359af
Followup Bug 1522233 - Fix test to check HorizontalRule top width instead of bottom
Fix taskcluster/mochitest failure from #4711
Comment 5•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Comment 6•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 66.0a1 (2019-01-25)
OS : Mac and Windows 10 Pro
Results attached QA Result : bug -1522233.png
Looks good to me.
Closing as verified.
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•