Closed Bug 1522238 Opened 6 years ago Closed 6 years ago

Set frame timestamps in MediaPipeline

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

66 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(1 file)

Bug 1515205 has a quick fix to set frame timestamps in VideoStreamEncoder::OnFrame. The proper place for this is in VideoConduit.

I think MediaPipeline makes more sense now that I've had a closer look.

Summary: Set frame timestamps in VideoConduit → Set frame timestamps in MediaPipeline

In the past we relied upon ViEEncoder::OnFrame to set the render time for
frames. With the branch 64 update, this code moved to
VideoStreamEncoder::OnFrame, and only sets the timestamp if it is greater than
the current time. This results in broken rtp timestamp estimates in the rtcp
sender report, which causes problems for Meet and possibly other services
that rewrite rtp timestamps based upon the sender report.

This patch explicitly sets the timestamp in MediaPipeline. This should give us
the same behaviour that we had before the branch update without requiring local
modifications to upstream code. This leaves the rtp timestamp as zero as that
was not being set before.

This also removes an unused overload of the VideoFrameConverted method.

Attachment #9045333 - Attachment description: Bug 1522238 - Set frame timestamp in MediaPipeline::ProcessVideoFrame; r=pehrsons! → Bug 1522238 - Set frame timestamp in MediaPipeline::ProcessVideoFrame; r=pehrsons
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19ca3722dde4 Set frame timestamp in MediaPipeline::ProcessVideoFrame; r=pehrsons
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Regressions: 1570673
No longer depends on: 1646904
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: