Enable LTO in aarch64-windows builds
Categories
(Firefox Build System :: Toolchains, enhancement)
Tracking
(firefox66 fixed)
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Our normal Windows nightlies get LTO enabled implicitly by the PGO logic, but since we don't have arm64 PGO builds, let's enable LTO explicitly there.
Our normal Windows nightlies get LTO enabled implicitly by the PGO logic, but since we don't have arm64 PGO builds, let's enable LTO explicitly there.
Comment 3•6 years ago
|
||
bugherder |
Comment 4•6 years ago
|
||
Seems like this affected Raptor on Windows 7 (both OPT & PGO builds):
== Change summary for alert #18883 (as of Thu, 24 Jan 2019 13:10:20 GMT) ==
Regressions:
6% raptor-webaudio-firefox windows7-32 opt 209.67 -> 221.58
4% raptor-webaudio-firefox windows7-32 pgo 223.62 -> 232.67
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=18883
Comment 5•6 years ago
|
||
:dmajor is there anything we can do to resolve this issue too?
I don't know what raptor is, can you point me to some documentation? In any case it's not possible for this bug to have affected Windows 7 builds, I think the blame should go to bug 1521129.
Let's move the raptor discussion to bug 1524087, where I already have a fix.
Comment 8•6 years ago
|
||
(In reply to David Major [:dmajor] from comment #6)
I don't know what raptor is, can you point me to some documentation? In any case it's not possible for this bug to have affected Windows 7 builds, I think the blame should go to bug 1521129.
You can read more about React tests from here: https://wiki.mozilla.org/Performance_sheriffing/Raptor
Description
•