Closed Bug 1522351 Opened 6 years ago Closed 6 years ago

Improve accuracy of subpixel box shadows

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: gw, Assigned: gw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

A fractional blur radius results in the inflation of the shadow rect moving the relative center of the primitive shadow rect.

This results in the box shadow being stretched incorrectly when applied to the clip mask.

Assignee: nobody → gwatson
Blocks: 1411693
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a347a546d90 Improve accuracy of subpixel box shadows. r=emilio

Backed out changeset 9a347a546d90 (Bug 1522351) for wrench bustage in reftests/boxshadow/no-stretch.png CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=223850961&revision=9a347a546d90d87842ca160c836f8d0305b14b99

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=223850961

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=223850961&repo=autoland&lineNumber=2662

[task 2019-01-24T20:18:09.557Z] REFTEST reftests/boxshadow/overlap1.yaml == reftests/boxshadow/overlap1.png
[task 2019-01-24T20:18:10.097Z] REFTEST reftests/boxshadow/overlap2.yaml == reftests/boxshadow/overlap2.png
[task 2019-01-24T20:18:10.674Z] REFTEST reftests/boxshadow/no-stretch.yaml == reftests/boxshadow/no-stretch.png
[task 2019-01-24T20:18:10.790Z] REFTEST TEST-UNEXPECTED-FAIL | reftests/boxshadow/no-stretch.yaml == reftests/boxshadow/no-stretch.png | image comparison, max difference: 100, number of differing pixels: 1463

Flags: needinfo?(gwatson)
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae27ea8a859f Backed out changeset 9a347a546d90 for wrench bustage in reftests/boxshadow/no-stretch.png CLOSED TREE

Updated the reference image and re-queued in lando.

Flags: needinfo?(gwatson)
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec5b5e910ce1 Improve accuracy of subpixel box shadows. r=emilio
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Blocks: 1446685
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: