Closed Bug 1522413 Opened 6 years ago Closed 6 years ago

WindowManagerMixin:open_chrome_window() registers focus event listeners too late

Categories

(Remote Protocol :: Marionette, enhancement, P2)

Product:
Remote Protocol
Component:
Marionette
Type:
enhancement

Tracking

(firefox66 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Bug 1522413 - [marionette] Register event listeners before focusing the new window in WindowManagerMixin.open_chrome_window(). r?ato
(deleted), text/x-phabricator-request
Details

The JS code in that method registers the event listeners for focus and activate after calling win.focus(). It means we have a race conditions for tests trying to open chrome windows.

The focus promise has to be setup before calling focus() on the window.

Blocks: 1521897
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P2
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9762341e99f9
[marionette] Register event listeners before focusing the new window in WindowManagerMixin.open_chrome_window(). r=ato

https://hg.mozilla.org/mozilla-central/rev/9762341e99f9

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: