Closed Bug 1522443 Opened 6 years ago Closed 6 years ago

Intermittent /visual-viewport/viewport-no-resize-event-on-overflow-recalc.html | Resize event not fired at window.visualViewport when content is added - assert_equals: expected false but got true

Categories

(Core :: Layout, defect, P5)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: botond)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered][wptsync upstream][stockwell unknown])

Attachments

(1 file)

Bug 1522443 - Avoid intermittent failure of viewport-no-resize-event-on-overflow-recalc.html. r=hiro
(deleted), text/x-phabricator-request
Details

Filed by: opoprus [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=223724432&repo=mozilla-central

https://queue.taskcluster.net/v1/task/QQBqbMBrQbK5UZKd7kLd3g/runs/0/artifacts/public/logs/live_backing.log

[task 2019-01-24T12:00:51.312Z] 12:00:51 INFO - TEST-START | /visual-viewport/viewport-no-resize-event-on-overflow-recalc.html
[task 2019-01-24T12:00:51.479Z] 12:00:51 INFO - Setting pref dom.visualviewport.enabled (true)
[task 2019-01-24T12:00:51.907Z] 12:00:51 INFO - Closing window 20
[task 2019-01-24T12:00:52.033Z] 12:00:52 INFO -
[task 2019-01-24T12:00:52.033Z] 12:00:52 INFO - TEST-UNEXPECTED-FAIL | /visual-viewport/viewport-no-resize-event-on-overflow-recalc.html | Resize event not fired at window.visualViewport when content is added - assert_equals: expected false but got true
[task 2019-01-24T12:00:52.034Z] 12:00:52 INFO - runTest/<@http://web-platform.test:8000/visual-viewport/viewport-no-resize-event-on-overflow-recalc.html:36:13
[task 2019-01-24T12:00:52.034Z] 12:00:52 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1566:20
[task 2019-01-24T12:00:52.034Z] 12:00:52 INFO - Test.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1606:17
[task 2019-01-24T12:00:52.034Z] 12:00:52 INFO - TEST-OK | /visual-viewport/viewport-no-resize-event-on-overflow-recalc.html | took 714ms

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE

Recent log failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245511394&repo=autoland&lineNumber=23388

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

Retriggers show this started spiking when bug 1477610 landed.

Botond, please take a look.

Flags: needinfo?(botond)
Regressed by: 1477610
Keywords: regression
Whiteboard: [retriggered] → [retriggered][stockwell needswork:owner]

This failure seems to happen mostly on linux 32 debug (or on android build), it's a slower platform. So it seems that waiting a rAF before proceeding the test is not sufficient. I have no idea about the way to tell whether there is still pending layout flushes or not. Waiting one more frame might fix most failures, also dropping viewport_support.js will help a bit since it's not used at all.

Hiro, thank you for the suggestions! I've tried them locally and with them in place, I could not trigger a failure in 30 minutes of repeated test runs, so they seem to have the desired effect.

Assignee: nobody → botond
Flags: needinfo?(botond)
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df182ef2d4e5 Avoid intermittent failure of viewport-no-resize-event-on-overflow-recalc.html. r=hiro

https://hg.mozilla.org/mozilla-central/rev/df182ef2d4e5

Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16873 for changes under testing/web-platform/tests
Whiteboard: [retriggered][stockwell needswork:owner] → [retriggered][stockwell needswork:owner][wptsync upstream]
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: