[de-xbl] Migrate freebusy-grid to custom element.
Categories
(Calendar :: General, enhancement)
Tracking
(Not tracked)
People
(Reporter: arshad, Assigned: arshad)
References
Details
Attachments
(1 file, 23 obsolete files)
(deleted),
patch
|
arshad
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
How it looks when making the dialog tall and then shrink it again.
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
The mis-aligned attendee list. The attendee-spacer-bottom should be at the bottom to align with the scrollbar.
Thanks for fixing the overpainting issue.
Assignee | ||
Comment 9•6 years ago
|
||
oops i uploaded an old patch.
Assignee | ||
Comment 10•6 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #8)
Created attachment 9040531 [details]
wrong-position.pngThe mis-aligned attendee list. The attendee-spacer-bottom should be at the bottom to align with the scrollbar.
the scrollbar is not visible on mac that's why I put padding instead of box.. I ll change it real quick.
Assignee | ||
Comment 11•6 years ago
|
||
I am not addressing the same height issue of attendees-list and grid in this patch..
Assignee | ||
Updated•6 years ago
|
Comment 12•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 13•6 years ago
|
||
Assignee | ||
Comment 14•6 years ago
|
||
this.currentItem._fireEvent error is not related to this patch.
Assignee | ||
Comment 15•6 years ago
|
||
Please let me know the comment that defines the freebusy-grid element and I ll update it. I can't come up with something that make sense.
Comment 16•6 years ago
|
||
Assignee | ||
Comment 17•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 18•6 years ago
|
||
Assignee | ||
Comment 19•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 20•6 years ago
|
||
Assignee | ||
Comment 21•6 years ago
|
||
Assignee | ||
Comment 22•6 years ago
|
||
Assignee | ||
Comment 23•6 years ago
|
||
Assignee | ||
Comment 24•6 years ago
|
||
Assignee | ||
Comment 25•6 years ago
|
||
Assignee | ||
Comment 26•6 years ago
|
||
Assignee | ||
Comment 27•6 years ago
|
||
Comment 28•6 years ago
|
||
Assignee | ||
Comment 29•6 years ago
|
||
Tried to write meaningful comments but they might not be up to your expection. Please suggest me the proper comment because I honestly don't exactly know what some methods do.
Assignee | ||
Comment 30•6 years ago
|
||
Comment 31•6 years ago
|
||
Assignee | ||
Comment 32•6 years ago
|
||
Assignee | ||
Comment 33•6 years ago
|
||
Assignee | ||
Comment 34•6 years ago
|
||
Assignee | ||
Comment 35•6 years ago
|
||
Comment 36•6 years ago
|
||
Assignee | ||
Comment 37•6 years ago
|
||
Assignee | ||
Comment 38•6 years ago
|
||
Assignee | ||
Comment 39•6 years ago
|
||
Comment 40•6 years ago
|
||
Assignee | ||
Comment 41•6 years ago
|
||
Assignee | ||
Comment 42•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 43•6 years ago
|
||
(In reply to Arshad Khan [:arshad] from comment #42)
Looks like the test that is failing, is not related to this patch.
Comment 44•6 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e851d7778932
Migrate freebusy-grid binding to custom element. r=philipp DONTBUILD
Comment 45•6 years ago
|
||
I ran the "failing" test locally before landing.
Description
•