Closed
Bug 1522529
Opened 6 years ago
Closed 6 years ago
Remove focus hack from the gURLBar getter and properly implement UrlbarInput focus and blur methods
Categories
(Firefox :: Address Bar, enhancement, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: standard8, Assigned: dao)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
browser/base/content/test/general/browser_newwindow_focus.js is failing when run with QuantumBar:
FAIL URLBar should be focused - [object XULFrameElement] == {} - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_newwindow_focus.js :: test_no_steal_focus/< :: line 91
Stack trace:
chrome://mochitests/content/browser/browser/base/content/test/general/browser_newwindow_focus.js:test_no_steal_focus/<:91
resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
chrome://mochitests/content/browser/browser/base/content/test/general/browser_newwindow_focus.js:test_no_steal_focus:70
chrome://mochikit/content/browser-test.js:Tester_execTest/<:1108
chrome://mochikit/content/browser-test.js:Tester_execTest:1099
chrome://mochikit/content/browser-test.js:nextTest/<:997
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
In the failing test results the XULFrameElement is the browser window, the {} is the gURLBar.inputField of the new window.
When I open a new window, the urlbar is focused, so this could be some sort of timing issue introduced with QuantumBar.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dao+bmo
Blocks: quantumbar-nightly-experiment
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: browser_newwindow_focus.js fails when run with QuantumBar (focus issues?) → Remove focus hack from the gURLBar getter and properly implement UrlbarInput focus and blur methods
|
|
Assignee | |
Comment 1•6 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb9849a4c577
Remove focus hack from the gURLBar getter and properly implement UrlbarInput focus and blur methods. r=adw
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•