Closed
Bug 1522590
Opened 6 years ago
Closed 6 years ago
[Hero] Hero Component Refinements
Categories
(Firefox :: New Tab Page, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: wolasi, Assigned: gsuntop)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
Hero
Fix bottom spacing on primary hero story
Font-size of titles for secondary story should be 13px
Remove empty <p> tag for excerpt
Remover borders from borderless hero variant
Title font-weight should 600
For 2/3, 1/3 Hero switch secondary stories to a list
Line-height for excerpt/desc for 2/3 and 1/3 hero primary story should be 20px
Line-height for excerpt for full-width hero primary story should be 24px
|
Reporter | |
Updated•6 years ago
|
Assignee: nobody → gsuntop
|
||
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/096e4bc28be2c09f7faaa5e2ccc1ecfceac437e6
Bug 1522590 – Hero Component Refinements (#4725)
* Fix bottom spacing on primary hero story
* Font-size of titles for secondary story should be 13px
* Remove empty <p> tag for excerpt
* Title font-weight should 600
* Remover borders from borderless hero variant
* For 2/3, 1/3 Hero switch secondary stories to a list
* line height tweaks
* enable ghost lines of copy for conssistent spacing
|
||
Updated•6 years ago
|
Iteration: --- → 66.4 - Jan 21 - 27
Priority: -- → P1
|
||
Updated•6 years ago
|
Keywords: github-merged
|
|
||
Comment 3•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
Assignee | |
Comment 5•6 years ago
|
||
No further QA required.
Status: RESOLVED → VERIFIED
Flags: needinfo?(gsuntop)
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•