Open Bug 1522879 Opened 6 years ago Updated 2 years ago

[meta] Turn on dom.ipc.processPriorityManager.enabled by default and let it ride out to release (macOS and Linux)

Categories

(Core :: DOM: Content Processes, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: mconley, Unassigned)

References

(Depends on 2 open bugs)

Details

(Keywords: meta)

This bug will track the work required to both evaluate the background process priority manager as appropriate to release, and (if so), to ship it to the release channel audience.

Depends on: 1523974
Blocks: 1184701
Depends on: 1532767
No longer blocks: 1184701
Depends on: 1548364

Mike, is there a plan to let processPriorityManager ride the trains? How will it impact Fission when one page may have many iframe processes?

Flags: needinfo?(mconley)

(In reply to Chris Peterson [:cpeterson] from comment #1)

Mike, is there a plan to let processPriorityManager ride the trains?

The processPriorityManager rode the trains out for Windows in Firefox 69. Since Fission spun up, I don't think there's been much attention paid to the processPriorityManager (which currently is tab-centric, as opposed to frame-centric).

How will it impact Fission when one page may have many iframe processes?

I believe on Windows, subframes in the foreground tab without a top-level frame also in the foreground will run with lower OS priority.

We should make the processPriorityManager care about when frames are in the foreground tab, or we should turn off the process priority manager.

I've filed bug 1618547 for that.

Flags: needinfo?(mconley)

(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)

The processPriorityManager rode the trains out for Windows in Firefox 69. Since Fission spun up, I don't think there's been much attention paid to the processPriorityManager (which currently is tab-centric, as opposed to frame-centric).

macOS and Linux remain

Depends on: 1618547
Priority: -- → P3
Summary: [meta] Turn on dom.ipc.processPriorityManager.enabled by default and let it ride out to release → [meta] Turn on dom.ipc.processPriorityManager.enabled by default and let it ride out to release (macOS and Linux)
Depends on: 1621721

(In reply to Chris Peterson [:cpeterson] from comment #3)

(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)

The processPriorityManager rode the trains out for Windows in Firefox 69. Since Fission spun up, I don't think there's been much attention paid to the processPriorityManager (which currently is tab-centric, as opposed to frame-centric).

macOS and Linux remain

Mike, do you know which work remains to do to enable the process priority manager on all tier1 platforms?

Flags: needinfo?(mconley)

(In reply to Florian Quèze [:florian] from comment #5)

Mike, do you know which work remains to do to enable the process priority manager on all tier1 platforms?

SetProcessPriority() (located in hal/Hal.h) needs to be implemented on platforms we want to support, which basically means figuring out the platform integration part of it, so this might be a better question for gcp. (The priority manager can be enabled on all platforms right now, it just doesn't actually change the OS priority.)

Flags: needinfo?(mconley) → needinfo?(gpascutto)

I believe this is bug https://bugzilla.mozilla.org/show_bug.cgi?id=1372543 which seems to be complicated on Linux at least.

Flags: needinfo?(gpascutto)
Depends on: 1394714, 1372543
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.