Closed
Bug 1523050
Opened 6 years ago
Closed 6 years ago
Hero layout shows hero item repeated as one of list item
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: pdahiya, Assigned: pdahiya)
References
Details
(Keywords: github-merged)
Attachments
(2 files)
QA Results : Bug - 1523050.png
Hero items with 2/3 and 1/3 layout format 5 items - 1 hero item and 4 list items displays hero item repeated in list items.
Probably a regression caused by not using recStartingPoint in List component with the fix here https://github.com/mozilla/activity-stream/pull/4729/files
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → pdahiya
|
|
Assignee | |
Updated•6 years ago
|
Iteration: --- → 66.4 - Jan 21 - 27
Priority: -- → P1
|
||
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/b8a9467bf6587cb0ce2e3316802bc308c0fa544d Bug 1523050 - Hero layout repeats hero item in displayed list items (#4740)
|
|
Assignee | |
Updated•6 years ago
|
Keywords: github-merged
|
||
Comment 3•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
Assignee | |
Comment 5•6 years ago
|
||
How to test:
- go to about:config
- search for discoverystream.config and set preference to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
- Open new tab and search for text ‘Hero’ to find rendered Hero components
- Inside each Hero component one should see a hero item and 4 list items.
- Hero item should not be repeated in the 4 list items.
Flags: needinfo?(pdahiya)
|
||
Comment 6•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-02-04)
OS : Mac and Windows 10 Pro
Results attached - QA Results : Bug - 1523050.png
Hero item is no longer repeated in the 4 list items.
Closing as verified.
|
|
||
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•