Fix animation delete time
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Bug 1522407 is going to address test_animation_performance_warning.html failure. It addressed test failure, but WebRenderBridgeParent still hit NS_ERROR.
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=223987095&repo=try&lineNumber=141628
Error message was "ASSERTION: Tried to delete invalid animation".
https://searchfox.org/mozilla-central/rev/88324fa347928412cb3e4c92418311b7ef5b4271/gfx/layers/wr/WebRenderBridgeParent.cpp#497
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #0)
Error message was "ASSERTION: Tried to delete invalid animation".
WebRenderBridgeParent::RemoveEpochDataPriorTo() has a problem. Animation was deleted too early in the following STR.
-[1] Request to delete an animation A by WebRenderBridgeParent::RecvDeleteCompositorAnimations()
-[2] Request to re-add the animation A by WebRenderParentCommand::TOpAddCompositorAnimations message
-[3] WebRenderBridgeParent::RemoveEpochDataPriorTo() deletes obsoleted animation
In the STR, [3] removed animation A even when [2] re-added animation A again. It should not be deleted.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
By comment 1, there could be a case that Animation does not run depends on a timing.
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Confirmed that attachment 9039478 [details] address the ASSERTION in comment 0.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4554d10890d7633a5cb66e9796c561ead8b9a255
Assignee | ||
Comment 5•6 years ago
|
||
Comment 7•6 years ago
|
||
bugherder |
Description
•