Closed Bug 1523274 Opened 6 years ago Closed 6 years ago

Flash URL-Classifier feature optimization

Categories

(Toolkit :: Safe Browsing, enhancement)

Product:
Toolkit
Component:
Safe Browsing
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file)

opt1.patch
(deleted), patch
dimi
: review+
Details | Diff | Splinter Review

At the moment we use this pattern:

uint32_t numFeatures =
(sizeof(sFlashFeaturesMap) / sizeof(sFlashFeaturesMap[0]));
for (uint32_t i = 0; i < numFeatures; ++i) { ...

When we can simply do:

for (const FlashFeature& flashFeature : sFlashFeaturesMap) {

https://searchfox.org/mozilla-central/rev/4faab2f1b697827b93e16cb798b22b197e5235c9/netwerk/url-classifier/UrlClassifierFeatureFlash.cpp#60-65

Attached patch opt1.patch (deleted) — — Splinter Review
Attachment #9039507 - Flags: review?(dlee)
Attachment #9039507 - Flags: review?(dlee) → review+
Depends on: 1514202
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/75a81f7ada1d Flash URL-Classifier feature optimization, r=dimi

https://hg.mozilla.org/mozilla-central/rev/75a81f7ada1d

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: