CSS outline property isn't applied on inputs with type submit or button
Categories
(Core :: Layout: Form Controls, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox65 | --- | unaffected |
firefox66 | + | verified |
firefox67 | --- | verified |
People
(Reporter: julienw, Assigned: emilio)
References
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
STR:
- Open
data:text/html,<style>input { outline: 5px solid blue }</style><input type='submit'/>
=> The outline isn't displayed at all.
This works in Chrome as expected.
This works for <button> elements.
OK in v65 20190124174741
KO in v66 20190127093605 => regression
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
I know the problem happens on Linux and Windows at least.
Reporter | ||
Comment 2•6 years ago
|
||
Reporter | ||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e2b466629175004d1b91ba3b9e587bd72b31673e&tochange=587615dad57e5336fbb3dc060cdadaad8078fcca
Regressed by: 587615dad57e Emilio Cobos Álvarez — Bug 1514338 - Remove unneeded special case in nsHTMLButtonControlFrame. r=bzbarsky
Assignee | ||
Comment 6•6 years ago
|
||
Sorry, should've seen this :(
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
Comment on attachment 9039554 [details]
Bug 1523285 - Don't clip outlines of a button input and such. r=bzbarsky
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
Outlines on some buttons may not show up.
Is this code covered by automated tests?
Yes
Has the fix been verified in Nightly?
No
Needs manual test from QE?
Yes
If yes, steps to reproduce
See comment 0
List of other uplifts needed
none
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
Restores the previous behavior in the most trivial way possible.
String changes made/needed
none
Comment 9•6 years ago
|
||
bugherder |
Comment 11•6 years ago
|
||
I have reproduced this issue using Firefox 67.0a1 (2019.01.28) and 66.0b4 on Win 10 x64.
I can confirm this issue is fixed, I verified on latest nightly Firefox 67.0a1 (2019.02.04) on Win 10 x64, macOS 10.13 and Ubuntu 18.04 x64.
Comment on attachment 9039554 [details]
Bug 1523285 - Don't clip outlines of a button input and such. r=bzbarsky
Fix for regression in 66, verified in nightly.
Let's uplift for beta 5.
[Triage Comment]
Comment 13•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Comment 14•6 years ago
|
||
I can confirm this issue is fixed, I verified on 66.0b5 on Win 10 x64, macOS 10.13 and Ubuntu 16.04 x64.
Updated•6 years ago
|
Updated•6 years ago
|
Description
•