Closed
Bug 1523332
Opened 6 years ago
Closed 6 years ago
Check if QuantumBar can work with a pref flip study (and fix if not)
Categories
(Firefox :: Address Bar, enhancement, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: standard8, Assigned: mak)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We are planning on doing a pref-flip roll-out for QuantumBar on nightly.
Whilst we know that changing the pref & restarting works fine, we need to be able to cope with a pref flip happening at almost any time - e.g. do we still work fine if a new window is opened after the pref flip?
We might need to check how @supports -moz-bool-pref("browser.urlbar.quantumbar") with respect the other places that we check the QuantumBar pref.
|
Assignee | |
Comment 1•6 years ago
|
||
I'll start investigating this
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
So, this is not trivial because of bindings, most of the times something is broken (like opening a new window after flipping the pref), I have a patch that works, but it's not the nicest.
Anyway it's worth starting the discussion/investigation, so I'll attach it and we'll go from there.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/7b3e30ae92a9
Allow to instant switch on and off the Quantum Bar. r=dao
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.
Description
•