Closed
Bug 1523333
Opened 6 years ago
Closed 6 years ago
Add textmarkers for all setTimeout calls
Categories
(Core :: Performance, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla67
People
(Reporter: jesup, Assigned: jesup)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mstange
:
review+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
In bug 1270059 we added markers for deferred timeouts; it's really useful when looking at a profile to know when timers fire (and when they were submitted).
We could also move them to a custom marker in the future if we want to add any fancier UI; as it is you can see the details by hovering.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9039564 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 2•6 years ago
|
||
incorporates bugfix for bug 1523506
Attachment #9039715 -
Flags: review?(mstange)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9039564 -
Attachment is obsolete: true
Attachment #9039564 -
Flags: review?(mstange)
|
||
Updated•6 years ago
|
Attachment #9039715 -
Flags: review?(mstange) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f8e8369238d
add setTimeout/Interval profiler markers for all uses r=mstange
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Is this something you may be looking to uplift? It affects 66 as well (in bug 1523506)
Flags: needinfo?(rjesup)
|
|
Assignee | |
Comment 7•6 years ago
|
||
Comment on attachment 9039715 [details] [diff] [review]
add setTimeout/Interval profiler markers for all uses
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
GECKO_PROFILER required to build without warning/error
Is this code covered by automated tests?
No
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
No
If yes, steps to reproduce
List of other uplifts needed
None
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
Only affects profiler and only when on; changes are trivial. If we want even less risk we can just ifdef the TimeStamp def
String changes made/needed
none
Flags: needinfo?(rjesup)
Attachment #9039715 -
Flags: approval-mozilla-beta?
Comment on attachment 9039715 [details] [diff] [review]
add setTimeout/Interval profiler markers for all uses
Enhancement for the profiler, should avoid a warning/error as well.
This should land for beta 4.
Attachment #9039715 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 9•6 years ago
|
||
| bugherder uplift | ||
status-firefox66:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•