Closed Bug 1523403 Opened 6 years ago Closed 5 years ago

Add more test coverage for Discovery Stream front end

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 69
Iteration:
69.3 - Jun 10 - 23
Tracking Flags:
Tracking Status
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: k88hudson, Assigned: pdahiya)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5090
(deleted), text/x-github-pull-request
Details

Right now our test coverage is lacking for a lot of of Discovery Stream React components. Let's improve this in order to prevent regressions. We also might want to enforce the data format via JSON schema.

Iteration: 67.1 - Jan 28 - Feb 10 → 67.2 - Feb 11 - 24
Assignee: khudson → nobody
Summary: Add client-side validation and normalisation of API data → Add more test coverage for Discoverty Stream front end
Iteration: 67.2 - Feb 11 - 24 → 68.1 - Mar 18 - 31
Priority: P1 → --
Priority: -- → P2

It would be a good idea to start with where code has regressed

Iteration: 68.1 - Mar 18 - 31 → ---
Summary: Add more test coverage for Discoverty Stream front end → Add more test coverage for Discovery Stream front end
Blocks: pocket-newtab-68
No longer blocks: 1512725
Blocks: pocket-newtab-69
Blocks: pocket-newtab
No longer blocks: pocket-newtab-69
No longer blocks: pocket-newtab-68

Next step: Determine the % goal for test coverage for 69 and make the gameplan.

Assignee: nobody → pdahiya
Iteration: --- → 69.1 - May 13 - 26
Priority: P2 → P1
Depends on: 1531099
Iteration: 69.1 - May 13 - 26 → 69.2 - May 27 - Jun 9
Iteration: 69.2 - May 27 - Jun 9 → 69.3 - Jun 10 - 23
Keywords: github-merged
Blocks: 1559536

https://hg.mozilla.org/mozilla-central/rev/0dff9f803849

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

status-firefox68: --- → ?
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: