Closed
Bug 1523412
Opened 6 years ago
Closed 6 years ago
GetStreamCaps can fail with S_FALSE
Categories
(Core :: WebRTC: Audio/Video, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: drno, Assigned: drno)
References
(Blocks 1 open bug)
Details
Crash Data
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → drno
Priority: -- → P2
|
|
Assignee | |
Comment 1•6 years ago
|
||
https://msdn.microsoft.com/en-us/windows/desktop/dd319787 explains that GetStreamCaps() can return S_FALSE, which is not caught by FAILED().
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
After merging we should also upstream this (as the latest Chromium code still has the same bug - even though the non-webrtc parts of Chromiums code check GetStreamCaps() return value properly - even with comments describing the problem here).
|
||
Updated•6 years ago
|
Blocks: webrtc_upstream_bugs
|
|
Assignee | |
Comment 6•6 years ago
|
||
Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf6287bb0477
compare GetStreamCaps return values against S_OK. r=dminor
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
|
||
Comment 9•6 years ago
|
||
Filed https://bugs.chromium.org/p/webrtc/issues/detail?id=10267 to track this upstream.
|
|
||
Comment 10•6 years ago
|
||
Upstream review: https://webrtc-review.googlesource.com/c/src/+/120644
|
|
||
Comment 11•6 years ago
|
||
|
||
Updated•5 years ago
|
Crash Signature: [@ webrtc::videocapturemodule::VideoCaptureDS::SetCameraOutput ]
You need to log in
before you can comment on or make changes to this bug.
Description
•