Skip test_videocontrols_onclickplay.html test
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
text/x-phabricator-request
|
Details |
During testing test_videocontrols_onclickplay.html, it hit ASSERT ain WebRenderBridgeParent.cpp
Assignee | ||
Comment 1•6 years ago
|
||
test_videocontrols_onclickplay.html belongs to mochitest-chrome and it runs test with e10s disabled. It caused hitting the assert.
Assignee | ||
Comment 2•6 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #1)
test_videocontrols_onclickplay.html belongs to mochitest-chrome and it runs test with e10s disabled. It caused hitting the assert.
In this case ImageBridgeChild::UpdateTextureFactoryIdentifier() is called at first for LayersBackend::LAYERS_WR and then for LayersBackend::LAYERS_BASIC.
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #2)
In this case ImageBridgeChild::UpdateTextureFactoryIdentifier() is called at first for LayersBackend::LAYERS_WR and then for LayersBackend::LAYERS_BASIC.
ImageBridgeChild::UpdateTextureFactoryIdentifier() for LayersBackend::LAYERS_BASIC was always called for eWindowType_invisible in parent process. The testing test_videocontrols_onclickplay.html run with e10s disabled, then it caused hitting the assert.
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
attachment 9040006 [details] [diff] [review] was not enough to address the test failure, since pop-up windows was also created.
https://treeherder.mozilla.org/#/jobs?repo=try&author=sikeda%40mozilla.com&selectedJob=224898163
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
I re-think about test_videocontrols_onclickplay.html. The test run with e10s disabled, and the test failure happens by disabling e10s. But WebRender is not used on windows with disabling e10s. Then we could skip the test for MVP.
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Comment 12•6 years ago
|
||
bugherder |
Description
•