MediaRecorder cannot record audio-only webm
Categories
(Core :: Audio/Video: Recording, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
Details
Attachments
(6 files)
The EbmlComposer that writes webm clusters refuses to flush a cluster unless a VP8 keyframe has been encoded, even if we're doing an audio-only recording.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D35169
|
|
Assignee | |
Comment 3•5 years ago
|
||
Somewhere along the way this must have gotten broken.
Until this, passing mime type to MediaRecorder has had no effect.
This patch does two things:
- Passes the mime type through from MediaRecorder to MediaEncoder
- Gives preference to the mime type when passed, wrt picking codecs,
however, we still yield to a video mime type when given a video track
since that's how both Firefox and Chromium function today.
Proper spec handling of mime type will be fixed in bug 1512175.
Depends on D35170
|
|
Assignee | |
Comment 4•5 years ago
|
||
From the previous patch, if ogg is disabled we'll fallback on video/webm.
So some tests relying on errors need it disabled too, in order to pass.
Depends on D35171
|
|
Assignee | |
Comment 5•5 years ago
|
||
This does two things:
- Makes the code for how flushing works actually readable (seriously).
- Allows audio-only webms.
Depends on D35172
|
|
Assignee | |
Comment 6•5 years ago
|
||
Depends on D35173
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e431e395e20e
https://hg.mozilla.org/mozilla-central/rev/944da9f033e8
https://hg.mozilla.org/mozilla-central/rev/7c42061bf905
https://hg.mozilla.org/mozilla-central/rev/f5a1371cca6e
https://hg.mozilla.org/mozilla-central/rev/6c52ecd21b30
https://hg.mozilla.org/mozilla-central/rev/d9f2bc3dd281
Description
•