Closed Bug 1523588 Opened 6 years ago Closed 6 years ago

Display the register contents in the first frame in AArch64 Windows crashes

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox67 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

The contents of all the registers are displayed in the first frame of the crashed thread when looking at a crash's "Raw dump" tab on Socorro. On Windows/AArch64 this isn't the case. Since I'm not sure if it's a problem with Breakpad or Socorro I'm filing it here for now.

Summary: Display the register contents in the first frame on AArch64 Windows crashes → Display the register contents in the first frame in AArch64 Windows crashes

(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #1)

There's code to support this, but perhaps it's broken due to Microsoft using a different context type for their AArch64 minidumps?
https://github.com/mozilla-services/socorro/blob/7ae773805a59076dea64c9c4bb112d0c458a291a/minidump-stackwalk/stackwalker.cc#L388

Thanks for the pointer. That code isn't being run because the cpu name is not "arm64" but "0x000c". This is fixed by bug 1519845, I just tested it locally. If you can review that and bug 1509805 we can then pull from upstream breakpad again and squash all these bugs in one go.

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Depends on: 1524265

The patches landed upstream and have been imported into Socorro. This is looking good, see this crash report with the register contents being properly shown in the first stack frame (raw dump tab): https://crash-stats.mozilla.com/report/index/f4242326-88e7-4f7d-981a-518c30190131

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.