Closed Bug 1523717 Opened 6 years ago Closed 5 years ago

Specifying paths in |mach try fuzzy| doesn't honour mochitest manifest annotations

Categories

(Developer Infrastructure :: Try, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1541424

People

(Reporter: ahal, Unassigned)

References

Details

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c7e7bb1b1c9138cac7b266dbf29b0e55bb3f9bc&selectedJob=224753195

In the above push the mda1 task has test failures from a test that is normally skipped. I believe this is a regression from bug 1489100 when we started converting directories into a list of tests (to support |mach try coverage|). I assume the mochitest harness has logic to ignore the manifest conditions if you pass in a test file explicitly (which makes sense for debugging purposes). But I haven't validated this theory yet.

Assuming my hunch is correct, I think the best way to fix this is to only expand directories into test paths if we're running |mach try coverage|.

Summary: Specifying paths in |mach try coverage| doesn't honour mochitest manifest annotations → Specifying paths in |mach try fuzzy| doesn't honour mochitest manifest annotations

It's also worth noting that this means manifest conditions will also be ignored when running |mach try coverage|. In this case we may need to add some sort of new flag to the test harnesses to make sure we honour skip-if conditions.

Priority: -- → P3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.