Move app menu notification DTD strings from browser.dtd to their own ftl file
Categories
(Firefox :: General, enhancement, P3)
Tracking
()
People
(Reporter: Gijs, Assigned: nautilus, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This panel has a number of different uses. AFAICT all the strings live in browser.dtd
They could be migrated to a separate ftl file (appMenuNotifications.ftl ). We can load it on-demand using MozXULElement.insertFTLIfNeeded
in https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/browser/components/customizableui/content/panelUI.js#738 . We should probably wait for the translations to be finished in the notification we're going to show before continuing to call openPopup().
We might then need to fix some automated tests that expect the panel to show synchronously in that case.
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Hey Gijs! I'm happy to work on this if it's still available.
Reporter | ||
Comment 2•6 years ago
|
||
(In reply to danielleleb12 from comment #1)
Hey Gijs! I'm happy to work on this if it's still available.
This (and the other deps of bug 1517304) is not a great place to start, unfortunately. Please talk to the mentors of the project you're interested in to find appropriate bugs for the project you want to work on.
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Comment 5•6 years ago
|
||
bugherder |
Updated•5 years ago
|
Updated•5 years ago
|
Description
•