Move the syncedTabs strings from browser.dtd to fluent
Categories
(Firefox :: Sync, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: Gijs, Assigned: chengy12, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The synced tabs sidebar ( https://searchfox.org/mozilla-central/source/browser/components/syncedtabs/sidebar.xhtml ) uses browser.dtd for its strings:
It should instead have its own FTL file.
The tricky bit is that some strings are used in the context menu for this sidebar in browser.xul .
To make those work, we'll need to insert the FTL file dynamically when the sidebar is shown. We can do this by calling MozXULElement.insertFTLIfNeeded() on the toplevel window from within sidebar.js ( https://searchfox.org/mozilla-central/source/browser/components/syncedtabs/sidebar.js ) when the page loads.
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Comment 3•6 years ago
|
||
Backed out changeset c0996caf797f (Bug 1523761) for bc failures in browser/components/customizableui/test/browser_947914_button_history.js CLOSED TREE
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234583292&repo=autoland&lineNumber=13351
Comment 6•6 years ago
|
||
bugherder |
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Description
•