Closed Bug 1523853 Opened 6 years ago Closed 5 years ago

Intermittent dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it

Categories

(Core :: DOM: Events, defect, P2)

Product:
Core
Component:
DOM: Events
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Assigned: bradwerth)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disabled])

Attachments

(6 files)

Bug 1523853 - Disable test_bug574663.html on Win7 and Linux (opt)
(deleted), text/x-phabricator-request
Details
enable_test_bug574663.html.diff
(deleted), patch
Details | Diff | Splinter Review
Bug 1523853 - Avoid racy synthesizeWheel calls in test_bug574663.html, r=kats
(deleted), text/x-phabricator-request
Details
Bug 1523853 Part 1: Change a mousewheel test to wait on the outcome, not the trigger.
(deleted), text/x-phabricator-request
Details
Bug 1523853 Part 2: Re-enable the mousewheel scroll/zoom test on Windows.
(deleted), text/x-phabricator-request
Details
Bug 1523853 Part 3: Further relax the mousewheel test to not care about the ending scroll values.
(deleted), text/x-phabricator-request
Details

#[markdown(off)]
Filed by: rgurzau [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=224906639&repo=mozilla-central

https://queue.taskcluster.net/v1/task/TcivAq9TTzytTOkqPyYIwA/runs/0/artifacts/public/logs/live_backing.log

06:28:15 INFO - TEST-START | dom/events/test/test_bug574663.html
06:28:15 INFO - TEST-INFO | started process screenshot
06:28:15 INFO - TEST-INFO | screenshot: exit 0
06:28:15 INFO - Buffered messages logged at 06:28:15
06:28:15 INFO - must wait for load
06:28:15 INFO - must wait for focus
06:28:15 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom
06:28:15 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll
06:28:15 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom, even after releasing the touchpad
06:28:15 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll, even after releasing the touchpad
06:28:15 INFO - Buffered messages finished
06:28:15 INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it
06:28:15 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:332:5
06:28:15 INFO - check@dom/events/test/test_bug574663.html:154:13
06:28:15 INFO - onpaint@dom/events/test/test_bug574663.html:37:7
06:28:15 INFO - waitForPaint@dom/events/test/test_bug574663.html:46:5
06:28:15 INFO - postApzFlush@dom/events/test/test_bug574663.html:58:5
06:28:15 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Ctrl-scrolling shouldn't scroll while the user is touching the touchpad
06:28:15 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Momentum scrolling shouldn't zoom, even when pressing Ctrl
06:28:15 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Momentum scrolling should scroll, even when pressing Ctrl
06:28:15 INFO - GECKO(5792) | MEMORY STAT | vsize 450MB | vsizeMaxContiguous 907MB | residentFast 68MB | heapAllocated 7MB
06:28:15 INFO - TEST-OK | dom/events/test/test_bug574663.html | took 293ms

Summary: Intermittent dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it → Intermittent TV dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it
Summary: Intermittent TV dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it → Intermittent dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it

There have been 38 failures within the last 7 days:

  • 1 on Linux x64 debug
  • 11 failures on os x 10.10 opt/debug
  • 26 failures on windows 7 x32 opt/pgo/debug

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226925440&repo=mozilla-inbound&lineNumber=8322

19:18:03 INFO - TEST-START | dom/events/test/test_bug574663.html
19:18:04 INFO - TEST-INFO | started process screenshot
19:18:04 INFO - TEST-INFO | screenshot: exit 0
19:18:04 INFO - Buffered messages logged at 19:18:03
19:18:04 INFO - must wait for load
19:18:04 INFO - must wait for focus
19:18:04 INFO - Buffered messages logged at 19:18:04
19:18:04 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom
19:18:04 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll
19:18:04 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom, even after releasing the touchpad
19:18:04 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll, even after releasing the touchpad
19:18:04 INFO - Buffered messages finished
19:18:04 INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it
19:18:04 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:332:5
19:18:04 INFO - check@dom/events/test/test_bug574663.html:154:13
19:18:04 INFO - onpaint@dom/events/test/test_bug574663.html:37:7
19:18:04 INFO - waitForPaint@dom/events/test/test_bug574663.html:46:5
19:18:04 INFO - postApzFlush@dom/events/test/test_bug574663.html:58:5
19:18:04 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Ctrl-scrolling shouldn't scroll while the user is touching the touchpad
19:18:04 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Momentum scrolling shouldn't zoom, even when pressing Ctrl
19:18:04 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Momentum scrolling should scroll, even when pressing Ctrl
19:18:04 INFO - GECKO(8788) | MEMORY STAT | vsize 526MB | vsizeMaxContiguous 989MB | residentFast 116MB | heapAllocated 15MB
19:18:04 INFO - TEST-OK | dom/events/test/test_bug574663.html | took 377ms

Flags: needinfo?(htsai)
Whiteboard: [stockwell needswork:owner]

Looking at the time the failure rate increased (~12 days ago), I wonder if there's something to do with bug 1521082. Edgar, could you please take a look?

Flags: needinfo?(htsai) → needinfo?(echen)

Bug 1521082 has nothing to do with the touchpad, it only affects the pointer event which is generated from touch screen.
This failure doesn't look like something related to bug 1521082.

Flags: needinfo?(echen)

Olli, do you recall changes landed recently that smell suspicious?

Flags: needinfo?(bugs)

yes, all my changes :) (well, everything related to refreshdriver scheduling changes)
Looking

Over the last 7 days this bug has 34 failures. These happen on linux64, osx-10-10, windows7-32.

Here is the latest log failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229543949&repo=autoland&lineNumber=32418

4:33:30 INFO - TEST-INFO | started process screenshot
04:33:30 INFO - TEST-INFO | screenshot: exit 0
04:33:30 INFO - Buffered messages logged at 04:33:30
04:33:30 INFO - must wait for load
04:33:30 INFO - must wait for focus
04:33:30 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom
04:33:30 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll
04:33:30 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom, even after releasing the touchpad
04:33:30 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll, even after releasing the touchpad
04:33:30 INFO - Buffered messages finished
04:33:30 INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it
04:33:30 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:332:16
04:33:30 INFO - check@dom/events/test/test_bug574663.html:154:13
04:33:30 INFO - onpaint@dom/events/test/test_bug574663.html:37:7
04:33:30 INFO - waitForPaint@dom/events/test/test_bug574663.html:46:11
04:33:30 INFO - postApzFlush@dom/events/test/test_bug574663.html:58:5
04:33:30 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Ctrl-scrolling shouldn't scroll while the user is touching the touchpad
04:33:30 INFO - GECKO(5432) | --DOCSHELL 161E7800 == 15 [pid = 3128] [id = {c62310de-9708-41c2-a6c8-fd5d538916fa}]
04:33:30 INFO - GECKO(5432) | --DOCSHELL 17753000 == 14 [pid = 3128] [id = {8d52388f-1a27-4024-9da8-d08fe91df466}]
04:33:30 INFO - GECKO(5432) | --DOMWINDOW == 31 (0D64F670) [pid = 3128] [serial = 19] [outer = 00000000] [url = about:blank]
04:33:30 INFO - GECKO(5432) | --DOMWINDOW == 30 (182B85E0) [pid = 3128] [serial = 23] [outer = 00000000] [url = about:blank]
04:33:30 INFO - GECKO(5432) | --DOMWINDOW == 29 (182B8710) [pid = 3128] [serial = 27] [outer = 00000000] [url = about:blank]
04:33:30 INFO - GECKO(5432) | --DOCSHELL 1774F400 == 13 [pid = 3128] [id = {84e4e7d1-e576-4cef-ba2f-b91eb9b2e0d1}]
04:33:30 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Momentum scrolling shouldn't zoom, even when pressing Ctrl
04:33:30 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Momentum scrolling should scroll, even when pressing Ctrl
04:33:30 INFO - GECKO(5432) | MEMORY STAT | vsize 563MB | vsizeMaxContiguous 535MB | residentFast 127MB | heapAllocated 17MB
04:33:31 INFO - TEST-OK | dom/events/test/test_bug574663.html | took 1199ms
04:33:31 INFO - GECKO(5432) | ++DOMWINDOW == 39 (0ED27400) [pid = 5344] [serial = 196] [outer = 085067A0]
04:33:31 INFO - TEST-START | dom/events/test/test_bug591815.html
04:33:31 INFO - GECKO(5432) | ++DOMWINDOW == 40 (00B69000) [pid = 5344] [serial = 197] [outer = 085067A0]
04:33:31 INFO - GECKO(5432) | MEMORY STAT | vsize 563MB | vsizeMaxContiguous 535MB | residentFast 126MB | heapAllocated 16MB
04:33:31 INFO - TEST-OK | dom/events/test/test_bug591815.html | took 122ms
04:33:31 INFO - GECKO(5432) | ++DOMWINDOW == 41 (0E774800) [pid = 5344] [serial = 198] [outer = 085067A0]
04:33:31 INFO - TEST-START | dom/events/test/test_bug593959.html
04:33:31 INFO - GECKO(5432) | ++DOMWINDOW == 42 (0E774C00) [pid = 5344] [serial = 199] [outer = 085067A0]
04:33:31 INFO - GECKO(5432) | ++DOCSHELL 08418000 == 8 [pid = 5344] [id = {2efadf90-d2c9-4ddc-8168-564fb5809e4a}]
04:33:31 INFO - GECKO(5432) | ++DOMWINDOW == 43 (08507120) [pid = 5344] [serial = 200] [outer = 00000000]

Flags: needinfo?(htsai)

This bug has failed 34 times in the last 7 days. Occurs on linux64, osx-10-10, windows7-32 on pgo, opt and debug build types.

Recent Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231390571&repo=autoland&lineNumber=7932

Olli are you still working on this?

There are 22 total failures in the last 7 days on linux64 pgo and windows7-32 pgo

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232926745&repo=autoland&lineNumber=8292

20:37:30 INFO - TEST-START | dom/events/test/test_bug574663.html
20:37:30 INFO - TEST-INFO | started process screenshot
20:37:31 INFO - TEST-INFO | screenshot: exit 0
20:37:31 INFO - Buffered messages logged at 20:37:30
20:37:31 INFO - must wait for load
20:37:31 INFO - must wait for focus
20:37:31 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom
20:37:31 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll
20:37:31 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom, even after releasing the touchpad
20:37:31 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll, even after releasing the touchpad
20:37:31 INFO - Buffered messages finished
20:37:31 INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it
20:37:31 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:332:16
20:37:31 INFO - check@dom/events/test/test_bug574663.html:154:13
20:37:31 INFO - onpaint@dom/events/test/test_bug574663.html:37:7
20:37:31 INFO - waitForPaint@dom/events/test/test_bug574663.html:46:11
20:37:31 INFO - postApzFlush@dom/events/test/test_bug574663.html:58:5
20:37:31 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Ctrl-scrolling shouldn't scroll while the user is touching the touchpad
20:37:31 INFO - Not taking screenshot here: see the one that was previously logged
20:37:31 INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Momentum scrolling shouldn't zoom, even when pressing Ctrl - got 1, expected 0.89552241563797
20:37:31 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:320:16
20:37:31 INFO - check@dom/events/test/test_bug574663.html:157:13
20:37:31 INFO - onpaint@dom/events/test/test_bug574663.html:37:7
20:37:31 INFO - EventListener.handleEventwaitForPaint@dom/events/test/test_bug574663.html:44:7
20:37:31 INFO - postApzFlush@dom/events/test/test_bug574663.html:58:5
20:37:31 INFO - Not taking screenshot here: see the one that was previously logged
20:37:31 INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Momentum scrolling should scroll, even when pressing Ctrl - got 20, expected 18
20:37:31 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:320:16
20:37:31 INFO - check@dom/events/test/test_bug574663.html:158:13
20:37:31 INFO - onpaint@dom/events/test/test_bug574663.html:37:7
20:37:31 INFO - EventListener.handleEventwaitForPaint@dom/events/test/test_bug574663.html:44:7
20:37:31 INFO - postApzFlush@dom/events/test/test_bug574663.html:58:5
20:37:31 INFO - GECKO(7220) | MEMORY STAT | vsize 522MB | vsizeMaxContiguous 592MB | residentFast 118MB | heapAllocated 15MB
20:37:31 INFO - TEST-OK | dom/events/test/test_bug574663.html | took 398ms

Flags: needinfo?(bugs)
Flags: needinfo?(bugs)

There are 24 total failures in the last 7 days on linux64 pgo, windows7-32 pgo.

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235717821&repo=mozilla-inbound&lineNumber=8808

[task 2019-03-24T11:29:57.678Z] 11:29:57 INFO - TEST-START | dom/events/test/test_bug574663.html
[task 2019-03-24T11:29:58.050Z] 11:29:58 INFO - TEST-INFO | started process screentopng
[task 2019-03-24T11:29:58.918Z] 11:29:58 INFO - TEST-INFO | screentopng: exit 0
[task 2019-03-24T11:29:58.919Z] 11:29:58 INFO - Buffered messages logged at 11:29:57
[task 2019-03-24T11:29:58.920Z] 11:29:58 INFO - must wait for load
[task 2019-03-24T11:29:58.921Z] 11:29:58 INFO - must wait for focus
[task 2019-03-24T11:29:58.923Z] 11:29:58 INFO - Buffered messages logged at 11:29:58
[task 2019-03-24T11:29:58.924Z] 11:29:58 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom
[task 2019-03-24T11:29:58.926Z] 11:29:58 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll
[task 2019-03-24T11:29:58.928Z] 11:29:58 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom, even after releasing the touchpad
[task 2019-03-24T11:29:58.929Z] 11:29:58 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll, even after releasing the touchpad
[task 2019-03-24T11:29:58.931Z] 11:29:58 INFO - Buffered messages finished
[task 2019-03-24T11:29:58.932Z] 11:29:58 INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it
[task 2019-03-24T11:29:58.934Z] 11:29:58 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:332:16
[task 2019-03-24T11:29:58.935Z] 11:29:58 INFO - check@dom/events/test/test_bug574663.html:154:13
[task 2019-03-24T11:29:58.937Z] 11:29:58 INFO - onpaint@dom/events/test/test_bug574663.html:37:7
[task 2019-03-24T11:29:58.939Z] 11:29:58 INFO - waitForPaint@dom/events/test/test_bug574663.html:46:11
[task 2019-03-24T11:29:58.940Z] 11:29:58 INFO - postApzFlush@dom/events/test/test_bug574663.html:58:5
[task 2019-03-24T11:29:58.942Z] 11:29:58 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Ctrl-scrolling shouldn't scroll while the user is touching the touchpad
[task 2019-03-24T11:29:58.943Z] 11:29:58 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Momentum scrolling shouldn't zoom, even when pressing Ctrl
[task 2019-03-24T11:29:58.945Z] 11:29:58 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Momentum scrolling should scroll, even when pressing Ctrl
[task 2019-03-24T11:29:58.946Z] 11:29:58 INFO - GECKO(7789) | MEMORY STAT | vsize 1524MB | residentFast 150MB | heapAllocated 23MB
[task 2019-03-24T11:29:58.948Z] 11:29:58 INFO - TEST-OK | dom/events/test/test_bug574663.html | took 504ms

Olli is there any progress here?

Flags: needinfo?(htsai)
Flags: needinfo?(bugs)
Flags: needinfo?(bugs)

Update:
There have been 32 failures within the last 7 days:

  • 5 failures on Linux x64 debug/opt
  • 11 failures on Linux x64 shippable opt
  • 1 failure on Linux64-shippable-qr opt
  • 3 failures on OS X 10.10 debug
  • 3 failures on OS X 10.10 shippable opt
  • 7 failures on Windows 7 opt/debug
  • 2 failures on Windows 7 Shippable opt

In the last 7 days there have been 57 occurrences on Windows and Linux build types opt and debug.

Whiteboard: [stockwell disable-recommended]

There are 82 failures in the last 7 days.
:smaug , can you please take a look?

Recent log snippet:
07:05:53 INFO - TEST-START | dom/events/test/test_bug574663.html
07:05:53 INFO - GECKO(3172) | JavaScript warning: chrome://global/content/bindings/tabbox.xml, line 162: Array.forEach is deprecated; use Array.prototype.forEach instead
07:05:53 INFO - GECKO(3172) | JavaScript warning: chrome://browser/content/browser-ctrlTab.js, line 568: Array.filter is deprecated; use Array.prototype.filter instead
07:05:53 INFO - TEST-INFO | started process screenshot
07:05:53 INFO - TEST-INFO | screenshot: exit 0
07:05:53 INFO - Buffered messages logged at 07:05:53
07:05:53 INFO - must wait for load
07:05:53 INFO - must wait for focus
07:05:53 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom
07:05:53 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll
07:05:53 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom, even after releasing the touchpad
07:05:53 INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll, even after releasing the touchpad
07:05:53 INFO - Buffered messages finished
07:05:53 INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it
07:05:53 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:332:16
07:05:53 INFO - check@dom/events/test/test_bug574663.html:154:13
07:05:53 INFO - onpaint@dom/events/test/test_bug574663.html:37:7
07:05:53 INFO - waitForPaint@dom/events/test/test_bug574663.html:46:11
07:05:53 INFO - postApzFlush@dom/events/test/test_bug574663.html:58:5

Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9bd381484c2a Disable test_bug574663.html on Win7 and Linux (opt) r=jmaher
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

https://hg.mozilla.org/mozilla-central/rev/9bd381484c2a

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → nbeleuzu
Status: RESOLVED → REOPENED
status-firefox68: fixed → ---
Keywords: leave-open
Resolution: FIXED → ---
Target Milestone: mozilla68 → ---
Priority: -- → P2
Attached patch enable_test_bug574663.html.diff (deleted) — — Splinter Review

Locally if one adds more kExtraEvents, the test starts to fail reliably - which is no wonder, synthesizeWheel is after all asynchronous and we have
if (++received == 2) { check in the wheel listener.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=36bd2d54cf3077aa62ceffca7fb1bb0559e10932

Flags: needinfo?(bugs)

Hi Olli, does this need to be landed? I don't see a reviewer.

Flags: needinfo?(bugs)

Still looking whether the patch helps here. And I think it does look promising.

Bug 1527055 is related, but that may get fixed soon once there are some generic fixes to IPC layer.

Flags: needinfo?(bugs)
Comment on attachment 9065753 [details] [diff] [review] enable_test_bug574663.html.diff Misusing data-review, since I had uploaded the patch to bugzilla :) I decided to keep kExtraEvents, and just make it 1, since kExtraEvents is used elsewhere to clarify expected test results. But I could just remove kExtraEvents and call synthesizeWheel(scrollbox, 10, 10, event, win); and then remove the one kExtraEvents usage.
Attachment #9065753 - Flags: data-review?(kats)
Comment on attachment 9065753 [details] [diff] [review] enable_test_bug574663.html.diff Review of attachment 9065753 [details] [diff] [review]: ----------------------------------------------------------------- Reviewed the phabricator version, clearing flag
Attachment #9065753 - Flags: data-review?(kats)
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c19a74cafdb7 Avoid racy synthesizeWheel calls in test_bug574663.html, r=kats
Keywords: regression
Assignee: nobody → bwerth
Attachment #9124376 - Attachment description: Bug 1523853: Change a mousewheel test to wait the on outcome, not the trigger. → Bug 1523853: Change a mousewheel test to wait on the outcome, not the trigger.
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9b2a47c687e Change a mousewheel test to wait on the outcome, not the trigger. r=kats

Brad, this was disabled on win because of frequent failures https://searchfox.org/mozilla-central/source/dom/events/test/mochitest.ini#78-79.
Do you think that with your fix we can re-enable the test on that platform?

Here is a try push with the test re-enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=89da756e856867f7a1a5b393780e912cee9d7877

(In reply to Alexandru Michis [:malexandru] from comment #51)

Brad, this was disabled on win because of frequent failures https://searchfox.org/mozilla-central/source/dom/events/test/mochitest.ini#78-79.
Do you think that with your fix we can re-enable the test on that platform?

The fix should make it more reliable on all platforms. I'll add another part to re-enable it on Windows.

Flags: needinfo?(bwerth)
Attachment #9124376 - Attachment description: Bug 1523853: Change a mousewheel test to wait on the outcome, not the trigger. → Bug 1523853 Part 1: Change a mousewheel test to wait on the outcome, not the trigger.
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ed185f0bea9e Part 2: Re-enable the mousewheel scroll/zoom test on Windows. r=kats
Regressions: 1613736

Looks like regressions have started to appear. The signature in Bug 1613736 is similar to what I get in local testing. A more aggressive fix to make the test non-intermittent would be to change the scroll expected results to check that the element has scrolled by some amount instead of by a calculated amount. This is what is done in the test for the changes to zoom. If it doesn't offend the purpose of the test, I can make that change.

There certainly are other tests that check that mousewheel scrolling happens in precise values. Basically anything that uses the constant DOM_DELTA_PIXEL. test_bug607464.html is one such example. I don't know why those tests are not intermittent and this one is. Changing this test to use non-specific tests would probably not reduce our overall test coverage.

I'm happy to make the change if Kats agrees. Kats is not accepting needinfo's now, so I'll just make the change and mark Kats as reviewer.

This is being done to reduce the intermittent failures we see in this test.
There are other non-intermittent tests that measure the specific number of
pixels traveled by mousewheel events. The focus of this test seems to be
"Ensure that mousewheel scrolling and zooming are mutually exclusive" and
this change maintains that.

Depends on D62067

Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/37ffe2e2412b Part 3: Further relax the mousewheel test to not care about the ending scroll values. r=kats

Looks like the last push has positively affected the intermittency rate. I'm claiming victory here. Feel free to needinfo me if it ticks up again.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: