Closed Bug 1524090 Opened 6 years ago Closed 6 years ago

add telemetry probe to capture GPU processing time

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: bdekoz, Assigned: jrmuizel)

References

Details

Attachments

(3 files)

A first attempt
(deleted), patch
Details | Diff | Splinter Review
request.md
(deleted), text/plain
chutten
: data-review+
Details
Bug 1524090. Add telemetry for GPU wait time.
(deleted), text/x-phabricator-request
Details

In discussing the WebRender status dashboard (1) with Matt Woodrow, he indicated that there are currently no probes that indicate the time where the GPU has finished processing submitted commands.

Such a probe would help improve coverage of telemetry probes over the full browser engine, and may be useful (or required?) for future W3C work on layout or navigation timing.

(1) - https://metrics.mozilla.com/webrender/dashboard.html

Attached patch A first attempt (deleted) — — Splinter Review

Here's a quick patch to capture the amount of time that we spend waiting on the GPU. This approach has the advantage of not requiring any additional GPU queries to implement and ends up only recording times where were actually blocked on the GPU.

Assignee: nobody → jmuizelaar
Blocks: 1532410
Attached file request.md (deleted) —
Attachment #9048509 - Flags: data-review?(chutten)
Comment on attachment 9048509 [details] request.md DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? No. This collection will expire in Firefox 82. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? Yes. :jrmuizel is responsible for renewing or removing the collection before it expires in Firefox 82. --- Result: datareview+
Attachment #9048509 - Flags: data-review?(chutten) → data-review+
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b73beb33ff1 Add telemetry for GPU wait time. r=mattwoodrow,chutten
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b58359864c3 Add telemetry for GPU wait time. r=mattwoodrow,chutten
Backout by nbeleuzu@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/2a08410b3cdc Backed out changeset 5b73beb33ff1 as per jmuizelaar`s req. CLOSED TREE

https://hg.mozilla.org/mozilla-central/rev/2b58359864c3

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: