Open Bug 1524249 Opened 5 years ago Updated 2 years ago

Pressing cmd-q multiple times on macOS when there are multiple tabs/windows open adds more quit confirmation / warning prompts / dialogs

Categories

(Firefox :: General, defect, P5)

Product:
Firefox
Component:
General
Version:
65 Branch
Platform:
Desktop
macOS
Type:
defect

Tracking

()

People

(Reporter: kislay, Unassigned)

References

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Using Mac OSX

  1. Start Firefox and open multiple tabs
  2. Press Command Q multiple times
  3. The prompt to confirm closing multiple tab will pop up again and again as many times as you pressed Command Q

Actual results:

The prompt to confirm closing multiple tab will pop up again and again as many times as you pressed Command Q

Expected results:

Successive Command Q should have been ignored with a warning ding after the prompt to confirm closing multiple tab will pops up.

Component: Untriaged → Keyboard Navigation
OS: Unspecified → macOS
Hardware: Unspecified → Desktop
Component: Keyboard Navigation → General
Keywords: regressionwindow-wanted
Priority: -- → P3

Issue is reproducible with the latest Nightly (2019-02-25).

  • Last good: 6e8e861540e6d8c85c73ab7b2afa1f027fb3750c
  • First bad: ca98b6f47b4e33673291a4dc2a4ebca28ce6db00

This is the best I could narrow it down:
Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6e8e861540e6d8c85c73ab7b2afa1f027fb3750c&tochange=ca98b6f47b4e33673291a4dc2a4ebca28ce6db00

Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regressionwindow-wanted
Blocks: 1438499
Flags: needinfo?(gijskruitbosch+bugs)

I don't think this is important. I'll see if I can find time to figure out why this happens (leaving ni for this), but even just treating this as a "regression" seems questionable, as we simply didn't show a prompt before at all. Gonna downgrade to P5. Feel free to upgrade back to P3 if I'm missing some convincing reason this is important (esp. over all the other regressions I'm dealing with atm that have actual user impact).

Priority: P3 → P5
Summary: Strange response when Command Q is pressed multiple times in OSX → Pressing cmd-q multiple times on macOS when there are multiple tabs/windows open adds more confirmation prompts
Flags: needinfo?(gijskruitbosch+bugs)

I keep looking for this bug and not finding it, going to try and make the summary easier to search for.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Pressing cmd-q multiple times on macOS when there are multiple tabs/windows open adds more confirmation prompts → Pressing cmd-q multiple times on macOS when there are multiple tabs/windows open adds more quit confirmation / warning prompts / dialogs

I can also reproduce this with alt+f4 on Linux and Windows 10, Nightly 89.0a1 (2021-04-07).

Bug 1706963 makes the earlier prompts close to not have multiple subsequent prompts appear when interacting with the earlier prompts. But as this bug suggests, we could potentially be smarter in reusing the current prompt. However, there are multiple ways to trigger these related prompts, so if the initial prompt is "close a single window with tabs" then a later prompt for "quit firefox (closing all windows)" then the latter one would probably be more important?

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1706963
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.