Closed Bug 1524313 Opened 6 years ago Closed 6 years ago

ImageCacheKey should use the right method to check if a window is 3rd party

Categories

(Core :: Graphics: ImageLib, enhancement)

Product:
Core
Component:
Graphics: ImageLib
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file)

Bug 1524313 - ImageCacheKey should use the right method to check if a window is 3rd party, r?ehsan
(deleted), text/x-phabricator-request
Details

https://searchfox.org/mozilla-central/rev/6e3cc153566f5f288ae768a2172385b8436d61dd/image/ImageCacheKey.cpp#135-137

As the comment says, we are checking here if a window is a 3rd party tracker. The correct function to use is: nsContentUtils::IsThirdPartyTrackingResourceWindow().

Note that this is just an optimization, because nsContentUtils::StorageDisabledByAntiTracking(), in the end, after several steps, calls IsThirdPartyTrackingResourceWindow() here:

https://searchfox.org/mozilla-central/rev/78cd247b5d7a08832f87d786541d3e2204842e8e/toolkit/components/antitracking/AntiTrackingCommon.cpp#969-972

Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c980928bd2d7 ImageCacheKey should use the right method to check if a window is 3rd party, r=Ehsan
Blocks: 1516540
Assignee: nobody → amarchesini

https://hg.mozilla.org/mozilla-central/rev/c980928bd2d7

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: