Add Message component
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
People
(Reporter: gsuntop, Assigned: gsuntop)
References
Details
(Keywords: github-merged)
Attachments
(4 files, 1 obsolete file)
Add a new Message component with the following schema:
- Header (text)
- Header Icon (text – URL)
- Subheader (text)
- Link Text (text)
- Link URL (text – URL)
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Blocked by discussion w. legal. Schema may change...
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 2•6 years ago
|
||
The Message component is part of dev-test-all
. Let me know when it's ready to be added to the basic
layout.
Updated•6 years ago
|
Comment 3•6 years ago
|
||
[Tracking Requested - why for this release]: uplift will be requested for Pocket NT experiments in 66
Comment 4•6 years ago
|
||
Updated•6 years ago
|
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Comment on attachment 9042224 [details]
Bug 1524322 - Add Message component to Discovery Stream
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
This component is used in the upcoming Pocket New Tab experience and will be used to deliver legal disclaimers to users.
Is this code covered by automated tests?
No
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
Yes
If yes, steps to reproduce
- Open
about:config
- Change
browser.newtabpage.activity-stream.discoverystream.config
to{"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
- Open a new tab
- Confirm that there's a component matching this comp: https://bug1524322.bmoattachments.org/attachment.cgi?id=9042229
List of other uplifts needed
None
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
This component is self-contained and has no external dependencies.
String changes made/needed
Updated•6 years ago
|
Comment 10•6 years ago
|
||
I have verified this issue with the latest Firefox Nightly (67.0a1 - Build ID: 20190211092917) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3 and I can confirm that the "Recommended by Pocket" component is matching the provided mock-ups.
Comment on attachment 9042224 [details]
Bug 1524322 - Add Message component to Discovery Stream
Verified in nightly, ok for uplift for beta 7 or 8.
Comment 12•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Description
•