Closed Bug 1524688 Opened 6 years ago Closed 6 years ago

Support JS components in static component manifests

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 2 open bugs, Regressed 1 open bug)

Details

Attachments

(66 files)

(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-github-pull-request
Details

Even with all of the native component registrations migrated to the static format, there are still over a hundred JS components that need to be registered dynamically. Migrating these to static entries will save us somewhere over 40K per process.

I intend to have these components load directly from JSMs, using the existing module loader infrastructure, which will significantly simplify the process from all sides, and also be considerably more efficient than the current system.

Blocks: 1524690

With most of the JS components converted to static registration, the string
arena and component hashtables are much smaller than the minimum space we
allocate for them.

That's going to break adding JS components when doing artifact builds, isn't it?

(In reply to Mike Hommey [:glandium] from comment #66)

That's going to break adding JS components when doing artifact builds, isn't it?

No, it will only break adding static registrations for JS components. Other forms of registration are still supported for now. But I'd generally like to discourage people from adding new JS components for things that aren't tied to C++ in any case.

Keywords: leave-open
https://hg.mozilla.org/integration/mozilla-inbound/rev/68eb174a337b20e64583ae8afd45d479a3f54b61 Bug 1524688: Part 1a - Support static registration JS components. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/d5dca413e2da67db3f7d52aefc669dd5d62c1142 Bug 1524688: Part 1b - Support static JavaScript components in browser_all_files_referenced. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/9201a7ea3c543310df1612b57ab72b883c94e07e Bug 1524688: Part 2 - Convert BrowserGlue and friends to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/ee28258a5724d708770adb03e5f31b37f7abcab2 Bug 1524688: Part 3 - Convert PeerConnection to static registration r=jib https://hg.mozilla.org/integration/mozilla-inbound/rev/6b3684e7d8f95c7d028fcf27d1570675a8ccbbef Bug 1524688: Part 4 - Convert UpdateService to static registration r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/56607c5a301a788f048fc3263027d2ca7ee6a138 Bug 1524688: Part 5 - Convert Places components to static registration r=mak https://hg.mozilla.org/integration/mozilla-inbound/rev/ab64ed7388ae516d1a33206399712f3e8860c087 Bug 1524688: Part 6 - Convert profile migrators to static registration r=MattN https://hg.mozilla.org/integration/mozilla-inbound/rev/5ce5986068f031ac17eb43ff278d30b81acdb73c Bug 1524688: Part 7 - Convert process singletons to static registration r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/fdc6c4ed241a50b756e77560bc22d2cbd13c684e Bug 1524688: Part 8 - Convert URL classifier to static registration r=Ehsan https://hg.mozilla.org/integration/mozilla-inbound/rev/4fb0f0a59fe22e150f1217d5558fed909f98259a Bug 1524688: Part 9 - Convert AddonManager components to static registration. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/25f982fd53bdbe1cf0b497fe7cc989928b9b0ac8 Bug 1524688: Part 10 - Convert password manager to static registration. r=MattN https://hg.mozilla.org/integration/mozilla-inbound/rev/9895239d8ac64bef30e5f6390f18456ffe209e4e Bug 1524688: Part 11 - Convert search service to static registration. r=mikedeboer https://hg.mozilla.org/integration/mozilla-inbound/rev/6dcacead17466ab4372253134218e0ea7b60f4da Bug 1524688: Part 12 - Convert prompter to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/b586d55d76d5012f0e4a471f4c207a8ae09cc393 Bug 1524688: Part 13 - Convert satchel to static registration. r=MattN https://hg.mozilla.org/integration/mozilla-inbound/rev/35a5f031dd1e63869a24f64d555743b85b5c1e83 Bug 1524688: Part 14 - Convert SimpleServices to static registration. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/38e1e42a0fb010f7dc15df14cfbe4e8d7a897165 Bug 1524688: Part 15 - Convert Weave to static registration. r=markh https://hg.mozilla.org/integration/mozilla-inbound/rev/28670fdc418d846f6cd9fcfeeff5f54d86efd9f8 Bug 1524688: Part 16 - Convert push components to static registration. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/911689ef9f33dbe026bad0c7e3d6ed4f030d6f29 Bug 1524688: Part 17 - Convert NetworkGeolocationProvider to static registration. r=jdm https://hg.mozilla.org/integration/mozilla-inbound/rev/ea347d57d73aca17f002b7d2ad9419175f889fb6 Bug 1524688: Part 18 - Convert presentation data channel stuff to static registration. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/d8efb5ed62b1acc9b4532ad63942adca75804a58 Bug 1524688: Part 19 - Convert PDF.j to static registration. r=bdahl https://hg.mozilla.org/integration/mozilla-inbound/rev/4ed0cf6be580167cfa4203a916179eb9e63f177c Bug 1524688: Part 20 - Convert URILoader components to static registration. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/4cbbb367ba0b558299e7a8fcb0bea092223cc831 Bug 1524688: Part 21 - Convert XULStore to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/dd89eb7e9b0d03d762b6bec4e90f5a956cdbe803 Bug 1524688: Part 22 - Convert URLFormatter to static registration. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/bf6b18e23f69cfc3b29560ae39cbd58e6b16ea6c Bug 1524688: Part 23 - Convert TooltipTextProvider to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/f4eaebbe2e0f424d9063dae50158bf53cb32781f Bug 1524688: Part 24 - Convert UpdateTimerManager to static registration. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/18f156d6355adadcce5dbb98ed9a9415e52a9684 Bug 1524688: Part 25 - Convert PageThumbsComponents to static registration. r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/fe583e7aae8d620c45a4a3638dea4d602d59e513 Bug 1524688: Part 26 - Convert TerminatorTelemetry to static registration. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/ff120b4eeb79dac8a4d69168521386947ac3de83 Bug 1524688: Part 27 - Convert TelemetryStartup to static registration. r=gfritzsche https://hg.mozilla.org/integration/mozilla-inbound/rev/2bd48db9cd0f95047e38cb64746ed07191c052c8 Bug 1524688: Part 29 - Convert RemoteWebNavigation to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/c9846136d105b809a859e63d95cd74c23ee7dd2c Bug 1524688: Part 30 - Convert DefaultCLH to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/df02f7d2521223ab89a886f7b9ba5858f3e94f37 Bug 1524688: Part 31 - Convert ShieldContentProcess to static registration. r=mythmon https://hg.mozilla.org/integration/mozilla-inbound/rev/5746311ef859095112efbc8a6b782eb3665d9102 Bug 1524688: Part 32 - Convert mozProtocolHandler to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/56f5c8f0d708a356efc8ecac09993216e73ae539 Bug 1524688: Part 33 - Convert mozIntl to static registration. r=zbraniecki https://hg.mozilla.org/integration/mozilla-inbound/rev/f509a5759fdf1062844c10edf2c26da48b7424e1 Bug 1524688: Part 34 - Convert gfx SanityTest to static registration. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/517838ee0c3cb67ecba24d826179dce8a367e628 Bug 1524688: Part 35 - Convert DownloadLegacy to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/a1dd5cec066e3d7ede0fa78b6afae04da897d1a3 Bug 1524688: Part 36 - Convert nsCrashMonitor to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/c819943ff4662c90150edcffa939d0bc4d7b99d3 Bug 1524688: Part 37 - Convert CrashService to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/56c61e0a1f45442c854424598801d5616009621c Bug 1524688: Part 38 - Convert ContentPrefService2 to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/1bb7dfbb9f48342377604a309ef4cdfcc21f8e13 Bug 1524688: Part 39 - Convert ClearDataService to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/01c4d3edb1b036819a562ab10844c9cb9f28dd9e Bug 1524688: Part 40 - Convert CaptiveDetect to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/995ea188bc31942f9f34e156c098e69a9fe3e1a4 Bug 1524688: Part 41 - Convert BHRTelemetry to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/fe9b6695212ec3960ab9e730ccc446a8c3da9375 Bug 1524688: Part 42 - Convert nsAsyncShutdown to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/09f626870ad036d0fcce32337ea1670dd96f7ef1 Bug 1524688: Part 43 - Convert RemoteSettingsComponents to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/e657e77d427124d39a80fa5418a76bbba02d479c Bug 1524688: Part 44 - Convert FxAccountsPush to static registration. r=markh https://hg.mozilla.org/integration/mozilla-inbound/rev/fe106b369a722814e2cfa3597ba1295f6deeae9e Bug 1524688: Part 45 - Convert network HTTP JS components to static registration. r=valentin https://hg.mozilla.org/integration/mozilla-inbound/rev/a9fb74beaf2b79c1a291dc223154815884fcb721 Bug 1524688: Part 46 - Convert DNSServiceDiscovery to static registration. r=valentin https://hg.mozilla.org/integration/mozilla-inbound/rev/28105bf7bf6a823ee2ec2baec25a881d8965b976 Bug 1524688: Part 47 - Convert RecordingCmdLine to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/978ef5dac9db2c03f10ef68d093c8780538b995e Bug 1524688: Part 48 - Convert PresentationControlService to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/12a9135dc005ca160564e968d7628803579ce2c9 Bug 1524688: Part 49 - Convert AndroidCastDataProvider to static registration. r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/183602e8a30b527608f2c862601abd83f275e636 Bug 1524688: Part 50 - Convert PresentationNetworkHelper to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/34a978503b1d411bcd1483b142fa8260d94d5870 Bug 1524688: Part 51 - Convert NotificationStorage to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/1e75ce91029b4eb030071e9802cd0bdbad59b9cf Bug 1524688: Part 53 - Convert htmlMenuBuilder to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/0ad5465eace1f9294f87ae8c705db322d5cfe953 Bug 1524688: Part 54 - Convert ConsoleAPIStorage to static registration. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/6c63bc2409729cf175b319cfb7cd95850aa1ab46 Bug 1524688: Part 55 - Convert BrowserElementParent to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/230d2feaf941443d88f9f5f65048c53d70e59b86 Bug 1524688: Part 56 - Convert contentAreaDropsListener to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/b4938f2ff8fd9f3af3914a1eefa991ab1c174706 Bug 1524688: Part 57 - Convert ProcessSelector to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/92877cf4fe33df2706fd03ad472f304da03482e5 Bug 1524688: Part 58 - Convert SlowScriptDebug to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/de0b9993bd5dceae296dfe863ea2455d15e2f6f1 Bug 1524688: Part 59 - Convert DevToolsStartup to static registration. r=ochameau https://hg.mozilla.org/integration/mozilla-inbound/rev/9e9ec7de41608a0752ae3867c7e77b034662ecb2 Bug 1524688: Part 60 - Convert PaymentUIService to static registration. r=MattN https://hg.mozilla.org/integration/mozilla-inbound/rev/0c1d1248e59ed6390e108dd1809627589c52c618 Bug 1524688: Part 61 - Convert AboutNewTabService to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/fb23a0271da0a68f19dcb12410a67dd127a05a4a Bug 1524688: Part 62 - Convert ContentDispatchChooser to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/c7c49f64048fcab4b5d010275b58ea7ff93a17c9 Bug 1524688: Part 63 - Convert HelperAppDlg to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/81dc12cc9257ba9c8f2eef578d99b142220b37a3 Bug 1524688: Part 64 - Reduce component manager allocations. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/328de611bcd3d1433140603488b131ae1c859236 Bug 1524688: Follow-up: Fix accidentally-removed manifest entry. r=bustage CLOSED TREE
https://hg.mozilla.org/integration/mozilla-inbound/rev/abaf68fe399ba6871f254b32ca6660892ff09da1 Bug 1524688: Part 1a - Support static registration JS components. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/042a975d3971e60f1edbaa8338332c0daa596b90 Bug 1524688: Part 1b - Support static JavaScript components in browser_all_files_referenced. r=mccr8

Backed out 2 changesets (bug 1524688) for build bustages at build/src/obj-firefox/xpcom/components/StaticComponents.cpp

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/1a199fcf0ef6e0c7b106e1820e8fb12c08e2dbab

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=042a975d3971e60f1edbaa8338332c0daa596b90&selectedJob=228509342

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228509342&repo=mozilla-inbound&lineNumber=13421

task 2019-02-14T22:50:40.929Z] 22:50:40 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/strres'
[task 2019-02-14T22:50:40.990Z] 22:50:40 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/strres'
[task 2019-02-14T22:50:40.990Z] 22:50:40 INFO - intl/strres/Unified_cpp_intl_strres0.o
[task 2019-02-14T22:50:40.990Z] 22:50:40 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/strres'
[task 2019-02-14T22:50:41.051Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-02-14T22:50:41.055Z] 22:50:41 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o Unified_cpp_xpcom_threads1.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/xpcom/threads -I/builds/worker/workspace/build/src/obj-firefox/xpcom/threads -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/caps -I/builds/worker/workspace/build/src/tools/profiler -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/Unified_cpp_xpcom_threads1.o.pp /builds/worker/workspace/build/src/obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads1.cpp
[task 2019-02-14T22:50:41.055Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-02-14T22:50:41.071Z] 22:50:41 INFO - make[4]: Nothing to be done for 'target'.
[task 2019-02-14T22:50:41.112Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/unicharutil/util'
[task 2019-02-14T22:50:41.112Z] 22:50:41 INFO - mkdir -p '.deps/'
[task 2019-02-14T22:50:41.112Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/unicharutil/util'
[task 2019-02-14T22:50:41.133Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/locale/tests/gtest'
[task 2019-02-14T22:50:41.133Z] 22:50:41 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o Unified_cpp_locale_tests_gtest0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/intl/locale/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/intl/locale/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/Unified_cpp_locale_tests_gtest0.o.pp /builds/worker/workspace/build/src/obj-firefox/intl/locale/tests/gtest/Unified_cpp_locale_tests_gtest0.cpp
[task 2019-02-14T22:50:41.133Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/locale/tests/gtest'
[task 2019-02-14T22:50:41.154Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/unicharutil/util'
[task 2019-02-14T22:50:41.154Z] 22:50:41 INFO - intl/unicharutil/util/Unified_cpp_unicharutil_util0.o
[task 2019-02-14T22:50:41.154Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/unicharutil/util'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/l10n'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - mkdir -p '.deps/'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/l10n'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/l10n'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - intl/l10n/Unified_cpp_intl_l10n0.o
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/l10n'
[task 2019-02-14T22:50:41.546Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/components'
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o StaticComponents.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/xpcom/components -I/builds/worker/workspace/build/src/obj-firefox/xpcom/components -I/builds/worker/workspace/build/src/obj-firefox/xpcom -I/builds/worker/workspace/build/src/xpcom/base -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/xpcom/ds -I/builds/worker/workspace/build/src/chrome -I/builds/worker/workspace/build/src/js/xpconnect/loader -I/builds/worker/workspace/build/src/layout/build -I/builds/worker/workspace/build/src/modules/libjar -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -MD -MP -MF .deps/StaticComponents.o.pp /builds/worker/workspace/build/src/obj-firefox/xpcom/components/StaticComponents.cpp
[task 2019-02-14T22:50:41.547Z] 22:50:41 ERROR - /builds/worker/workspace/build/src/obj-firefox/xpcom/components/StaticComponents.cpp:5718:47: error: no matching function for call to 'ArrayLengthHelper'
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - auto jsms = MakeUnique<nsTArray<nsCString>>(MOZ_ARRAY_LENGTH(gComponentJSMs));
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:179:12: note: expanded from macro 'MOZ_ARRAY_LENGTH'
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - sizeof(mozilla::detail::ArrayLengthHelper(array))
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:164:8: note: candidate template ignored: substitution failure [with T = const mozilla::xpcom::StringOffset, N = 0]: zero-length arrays are not permitted in C++
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - char (&ArrayLengthHelper(T (&array)[N]))[N];
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - ^ ~
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - 1 error generated.
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - /builds/worker/workspace/build/src/config/rules.mk:812: recipe for target 'StaticComponents.o' failed
[task 2019-02-14T22:50:41.552Z] 22:50:41 ERROR - make[4]: *** [StaticComponents.o] Error 1
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/components'
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'xpcom/components/target' failed
[task 2019-02-14T22:50:41.552Z] 22:50:41 ERROR - make[3]: *** [xpcom/components/target] Error 2
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - make[3]: *** Waiting for unfinished jobs....

Flags: needinfo?(kmaglione+bmo)
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c2617631c8cd44710408458ed07c0d9f54e5781 Bug 1524688: Part 1a - Support static registration JS components. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/df8ab98551c15e956da71cb96dbede239a9a40eb Bug 1524688: Part 1b - Support static JavaScript components in browser_all_files_referenced. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/91616590f2cda5d97ce0379050f79c37310788bf Bug 1524688: Part 2 - Convert BrowserGlue and friends to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/c887c1baca245772921e86c299767a5ec7714514 Bug 1524688: Part 3 - Convert PeerConnection to static registration r=jib https://hg.mozilla.org/integration/mozilla-inbound/rev/c6130519c7cc4bb8dbdca524b65f3880dfa80296 Bug 1524688: Part 4 - Convert UpdateService to static registration r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/d9afb8bdd3af8d82508d938def2c710c9963fe50 Bug 1524688: Part 5 - Convert Places components to static registration r=mak https://hg.mozilla.org/integration/mozilla-inbound/rev/b53e94682c7d4fbcfd309d3522d1c49187ae0466 Bug 1524688: Part 6 - Convert profile migrators to static registration r=MattN https://hg.mozilla.org/integration/mozilla-inbound/rev/c787c503e7ccff211cd9ea6cf7f7ad6ebc65f58a Bug 1524688: Part 7 - Convert process singletons to static registration r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/39fdb923b0f1eda11fe6f16618f32939a93f02dd Bug 1524688: Part 8 - Convert URL classifier to static registration r=Ehsan https://hg.mozilla.org/integration/mozilla-inbound/rev/7dfbef2f4d9e3808c8d243e2aea07bcc5faf4913 Bug 1524688: Part 9 - Convert AddonManager components to static registration. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/b1dfd8a76cf13fcc444860a2c18b336a1a045910 Bug 1524688: Part 10 - Convert password manager to static registration. r=MattN https://hg.mozilla.org/integration/mozilla-inbound/rev/165bdb5717f30118fdf71a3d215db854e97ddb34 Bug 1524688: Part 11 - Convert search service to static registration. r=mikedeboer https://hg.mozilla.org/integration/mozilla-inbound/rev/3d7060d92f90e4a86f675bcc249b304a37f6c1e0 Bug 1524688: Part 12 - Convert prompter to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/5e00a19796e9cb348c25d7a9b98ca611be463992 Bug 1524688: Part 13 - Convert satchel to static registration. r=MattN https://hg.mozilla.org/integration/mozilla-inbound/rev/42d8d20de8316fa59c7d41cb9b553657cea40cc8 Bug 1524688: Part 14 - Convert SimpleServices to static registration. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/72bba92c04be116693878e332b90518867369832 Bug 1524688: Part 15 - Convert Weave to static registration. r=markh https://hg.mozilla.org/integration/mozilla-inbound/rev/97970d276725ea1ae7d1fd4d0cda2132d2452b72 Bug 1524688: Part 16 - Convert push components to static registration. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/2c74368a599dc58d7319f559efae08a2ba9af214 Bug 1524688: Part 17 - Convert NetworkGeolocationProvider to static registration. r=jdm https://hg.mozilla.org/integration/mozilla-inbound/rev/f7bd60e66927cf32d4bf0269c127b98a0fcfa5eb Bug 1524688: Part 18 - Convert presentation data channel stuff to static registration. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/c92b9ee33de73ab4a92a3f8551c3ed80fc390f7c Bug 1524688: Part 19 - Convert PDF.j to static registration. r=bdahl https://hg.mozilla.org/integration/mozilla-inbound/rev/258ee5ceb51f1cb8b1fb5c2857862f48e769ebfd Bug 1524688: Part 20 - Convert URILoader components to static registration. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/180b98f7073f2c253d3f566576ba1d2733f1bc11 Bug 1524688: Part 21 - Convert XULStore to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/d385ebcb283f1b4dae3b7b7241cbb6ff016abb0d Bug 1524688: Part 22 - Convert URLFormatter to static registration. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/cd87fc8903f76333284ff16ab24d1323b5d2741a Bug 1524688: Part 23 - Convert TooltipTextProvider to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/1d60cf9b20477f30ceaa47a3bceeabdf95eb3902 Bug 1524688: Part 24 - Convert UpdateTimerManager to static registration. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/cac8dcbeb88371db47043cbb7549923312c7b265 Bug 1524688: Part 25 - Convert PageThumbsComponents to static registration. r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/3013394923948e6ca4803c85aa714c6e30df1626 Bug 1524688: Part 26 - Convert TerminatorTelemetry to static registration. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/27da2eea89f1274770abe2a1f3e4755e75d13586 Bug 1524688: Part 27 - Convert TelemetryStartup to static registration. r=gfritzsche https://hg.mozilla.org/integration/mozilla-inbound/rev/9845f8c1a4e522c3a5351fabbb3d138cf89ec094 Bug 1524688: Part 29 - Convert RemoteWebNavigation to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/4e4440d26242ad8fbfaf5d7315371576955a4d6c Bug 1524688: Part 30 - Convert DefaultCLH to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/142bfed3ea38349cb2efe26a6312baeaec91909f Bug 1524688: Part 31 - Convert ShieldContentProcess to static registration. r=mythmon https://hg.mozilla.org/integration/mozilla-inbound/rev/f86c8798847ee702df944095639da4b425b894bf Bug 1524688: Part 32 - Convert mozProtocolHandler to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/ea73c355d08c0d1dfffe0b2c2730e23dffc8930a Bug 1524688: Part 33 - Convert mozIntl to static registration. r=zbraniecki https://hg.mozilla.org/integration/mozilla-inbound/rev/ad0168bf0506488b1891ae1b14ab4a5637013e93 Bug 1524688: Part 34 - Convert gfx SanityTest to static registration. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd9f80c2e022ea03cc8de1b057525f0e783cc05 Bug 1524688: Part 35 - Convert DownloadLegacy to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/57fc958412b6c2b522667ee64e039865645c2133 Bug 1524688: Part 36 - Convert nsCrashMonitor to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/f06fc063811c66f25d2dcf47babd8462f69b9121 Bug 1524688: Part 37 - Convert CrashService to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/e1708f3e99908b13f51ce23ad1a106b0e91409f9 Bug 1524688: Part 38 - Convert ContentPrefService2 to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/4c6bf381fc8af38e9ffc76d2476b285188999ed6 Bug 1524688: Part 39 - Convert ClearDataService to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/785f158f7ec34ad796005689a9b6b19ab8d3c75f Bug 1524688: Part 40 - Convert CaptiveDetect to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/e095356d248fb1adb7a0061d8bdfe61c7b15c497 Bug 1524688: Part 41 - Convert BHRTelemetry to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/6949d8a480a77f497a4eeb9812997e2642fcb6ab Bug 1524688: Part 42 - Convert nsAsyncShutdown to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/397ce6923d23e4f4f9dbc4c0d0c8ede78b032bcf Bug 1524688: Part 43 - Convert RemoteSettingsComponents to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/254429537792f4bad34fe4012cdeaa96b02d278d Bug 1524688: Part 44 - Convert FxAccountsPush to static registration. r=markh https://hg.mozilla.org/integration/mozilla-inbound/rev/ac097acb51f7d633a3e76f9226bc5fbddaf62f16 Bug 1524688: Part 45 - Convert network HTTP JS components to static registration. r=valentin https://hg.mozilla.org/integration/mozilla-inbound/rev/27ba0320a22e0e94f9a57a873a7f35b196cbd9b5 Bug 1524688: Part 46 - Convert DNSServiceDiscovery to static registration. r=valentin https://hg.mozilla.org/integration/mozilla-inbound/rev/83bacdb5fa9dc3cc638bae50daf5146352fb760e Bug 1524688: Part 47 - Convert RecordingCmdLine to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/844dce347667813a51279e05a76a4c22f730b8c6 Bug 1524688: Part 48 - Convert PresentationControlService to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/c1fd1a4cd1a2c6aa5ea16aa539f3c11647c6818f Bug 1524688: Part 49 - Convert AndroidCastDataProvider to static registration. r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/b8b0ce631921c9ba4f0e3aa9870578ff90381f10 Bug 1524688: Part 50 - Convert PresentationNetworkHelper to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/f63175b13c165e37dafd5ee8db2db183d6f6ef07 Bug 1524688: Part 51 - Convert NotificationStorage to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb7f117c3869c75fb9902012e19b5803768b58e Bug 1524688: Part 53 - Convert htmlMenuBuilder to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/e99e560806dd3589dcae1ea5fcb48294593cf761 Bug 1524688: Part 54 - Convert ConsoleAPIStorage to static registration. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/48e1be308f3a1dbc653b221a1884107334ce87bf Bug 1524688: Part 55 - Convert BrowserElementParent to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/e13a97f2f4bac502ced1a05e1ecd75428459bdd2 Bug 1524688: Part 56 - Convert contentAreaDropsListener to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/c23fdd4bfb7248fc757abbb157c5727ce7601fc8 Bug 1524688: Part 57 - Convert ProcessSelector to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/6c9e064daea634e354f33c0a7423672d8dc97d28 Bug 1524688: Part 58 - Convert SlowScriptDebug to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/d40113ddd74da893cd367f59c668a0bd3a9e5ce3 Bug 1524688: Part 59 - Convert DevToolsStartup to static registration. r=ochameau https://hg.mozilla.org/integration/mozilla-inbound/rev/4816d23cb8eb91512c5cb0d071ac565239be2fba Bug 1524688: Part 60 - Convert PaymentUIService to static registration. r=MattN https://hg.mozilla.org/integration/mozilla-inbound/rev/8276ffc51b70bcf22367cc933c272eab18f01e47 Bug 1524688: Part 61 - Convert AboutNewTabService to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/603593d5501b94886ea3a6bff55882cad430c0a9 Bug 1524688: Part 62 - Convert ContentDispatchChooser to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/4d3fbd27d326087985aa6adf32b250213a21e4be Bug 1524688: Part 63 - Convert HelperAppDlg to static registration. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/c999e7890f8b162eff7440311cb4cefd9d0835a8 Bug 1524688: Part 64 - Reduce component manager allocations. r=froydnj

https://hg.mozilla.org/mozilla-central/rev/3c2617631c8c
https://hg.mozilla.org/mozilla-central/rev/df8ab98551c1
https://hg.mozilla.org/mozilla-central/rev/91616590f2cd
https://hg.mozilla.org/mozilla-central/rev/c887c1baca24
https://hg.mozilla.org/mozilla-central/rev/c6130519c7cc
https://hg.mozilla.org/mozilla-central/rev/d9afb8bdd3af
https://hg.mozilla.org/mozilla-central/rev/b53e94682c7d
https://hg.mozilla.org/mozilla-central/rev/c787c503e7cc
https://hg.mozilla.org/mozilla-central/rev/39fdb923b0f1
https://hg.mozilla.org/mozilla-central/rev/7dfbef2f4d9e
https://hg.mozilla.org/mozilla-central/rev/b1dfd8a76cf1
https://hg.mozilla.org/mozilla-central/rev/165bdb5717f3
https://hg.mozilla.org/mozilla-central/rev/3d7060d92f90
https://hg.mozilla.org/mozilla-central/rev/5e00a19796e9
https://hg.mozilla.org/mozilla-central/rev/42d8d20de831
https://hg.mozilla.org/mozilla-central/rev/72bba92c04be
https://hg.mozilla.org/mozilla-central/rev/97970d276725
https://hg.mozilla.org/mozilla-central/rev/2c74368a599d
https://hg.mozilla.org/mozilla-central/rev/f7bd60e66927
https://hg.mozilla.org/mozilla-central/rev/c92b9ee33de7
https://hg.mozilla.org/mozilla-central/rev/258ee5ceb51f
https://hg.mozilla.org/mozilla-central/rev/180b98f7073f
https://hg.mozilla.org/mozilla-central/rev/d385ebcb283f
https://hg.mozilla.org/mozilla-central/rev/cd87fc8903f7
https://hg.mozilla.org/mozilla-central/rev/1d60cf9b2047
https://hg.mozilla.org/mozilla-central/rev/cac8dcbeb883
https://hg.mozilla.org/mozilla-central/rev/301339492394
https://hg.mozilla.org/mozilla-central/rev/27da2eea89f1
https://hg.mozilla.org/mozilla-central/rev/9845f8c1a4e5
https://hg.mozilla.org/mozilla-central/rev/4e4440d26242
https://hg.mozilla.org/mozilla-central/rev/142bfed3ea38
https://hg.mozilla.org/mozilla-central/rev/f86c8798847e
https://hg.mozilla.org/mozilla-central/rev/ea73c355d08c
https://hg.mozilla.org/mozilla-central/rev/ad0168bf0506
https://hg.mozilla.org/mozilla-central/rev/8dd9f80c2e02
https://hg.mozilla.org/mozilla-central/rev/57fc958412b6
https://hg.mozilla.org/mozilla-central/rev/f06fc063811c
https://hg.mozilla.org/mozilla-central/rev/e1708f3e9990
https://hg.mozilla.org/mozilla-central/rev/4c6bf381fc8a
https://hg.mozilla.org/mozilla-central/rev/785f158f7ec3
https://hg.mozilla.org/mozilla-central/rev/e095356d248f
https://hg.mozilla.org/mozilla-central/rev/6949d8a480a7
https://hg.mozilla.org/mozilla-central/rev/397ce6923d23
https://hg.mozilla.org/mozilla-central/rev/254429537792
https://hg.mozilla.org/mozilla-central/rev/ac097acb51f7
https://hg.mozilla.org/mozilla-central/rev/27ba0320a22e
https://hg.mozilla.org/mozilla-central/rev/83bacdb5fa9d
https://hg.mozilla.org/mozilla-central/rev/844dce347667
https://hg.mozilla.org/mozilla-central/rev/c1fd1a4cd1a2
https://hg.mozilla.org/mozilla-central/rev/b8b0ce631921
https://hg.mozilla.org/mozilla-central/rev/f63175b13c16
https://hg.mozilla.org/mozilla-central/rev/2cb7f117c386
https://hg.mozilla.org/mozilla-central/rev/e99e560806dd
https://hg.mozilla.org/mozilla-central/rev/48e1be308f3a
https://hg.mozilla.org/mozilla-central/rev/e13a97f2f4ba
https://hg.mozilla.org/mozilla-central/rev/c23fdd4bfb72
https://hg.mozilla.org/mozilla-central/rev/6c9e064daea6
https://hg.mozilla.org/mozilla-central/rev/d40113ddd74d
https://hg.mozilla.org/mozilla-central/rev/4816d23cb8eb
https://hg.mozilla.org/mozilla-central/rev/8276ffc51b70
https://hg.mozilla.org/mozilla-central/rev/603593d5501b
https://hg.mozilla.org/mozilla-central/rev/4d3fbd27d326
https://hg.mozilla.org/mozilla-central/rev/c999e7890f8b
https://hg.mozilla.org/mozilla-central/rev/149562860c06

Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/e81d47616fa7 Port bug 1524688: Remove 110 entries from the package manifest. rs=bustage-fix CLOSED TREE
Depends on: 1528896
Flags: needinfo?(kmaglione+bmo)
Keywords: leave-open
https://hg.mozilla.org/integration/mozilla-inbound/rev/280ea49c019b9bb8c19d265056e49a6ac08555d1 Bug 1524688: Part 28 - Convert SecurityReporter to static registration. r=johannh https://hg.mozilla.org/integration/mozilla-inbound/rev/f8fb6e47bb24093cb635cb475d1ff3df2d8697b0 Bug 1524688: Part 52 - Convert WebVTT components to static registration. r=heycam
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/838dbfa07a7b Port bug 1524688, part 28 and 52: Remove SecurityReporter.manifest/js and WebVTT*.js from package manifests. rs=bustage-fix DONTBUILD
Regressions: 1543845
No longer regressions: 1543845
Regressions: 1546424
Regressions: 1547331
Regressions: 1548869
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: