Support JS components in static component manifests
Categories
(Core :: XPCOM, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 2 open bugs, Regressed 1 open bug)
Details
Attachments
(66 files)
(deleted),
text/x-phabricator-request
|
Details | |
Bug 1524688: Part 1b - Support static JavaScript components in browser_all_files_referenced. r=mccr8
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-github-pull-request
|
Details |
Even with all of the native component registrations migrated to the static format, there are still over a hundred JS components that need to be registered dynamically. Migrating these to static entries will save us somewhere over 40K per process.
I intend to have these components load directly from JSMs, using the existing module loader infrastructure, which will significantly simplify the process from all sides, and also be considerably more efficient than the current system.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
Assignee | ||
Comment 13•6 years ago
|
||
Assignee | ||
Comment 14•6 years ago
|
||
Assignee | ||
Comment 15•6 years ago
|
||
Assignee | ||
Comment 16•6 years ago
|
||
Assignee | ||
Comment 17•6 years ago
|
||
Assignee | ||
Comment 18•6 years ago
|
||
Assignee | ||
Comment 19•6 years ago
|
||
Assignee | ||
Comment 20•6 years ago
|
||
Assignee | ||
Comment 21•6 years ago
|
||
Assignee | ||
Comment 22•6 years ago
|
||
Assignee | ||
Comment 23•6 years ago
|
||
Assignee | ||
Comment 24•6 years ago
|
||
Assignee | ||
Comment 25•6 years ago
|
||
Assignee | ||
Comment 26•6 years ago
|
||
Assignee | ||
Comment 27•6 years ago
|
||
Assignee | ||
Comment 28•6 years ago
|
||
Assignee | ||
Comment 29•6 years ago
|
||
Assignee | ||
Comment 30•6 years ago
|
||
Assignee | ||
Comment 31•6 years ago
|
||
Assignee | ||
Comment 32•6 years ago
|
||
Assignee | ||
Comment 33•6 years ago
|
||
Assignee | ||
Comment 34•6 years ago
|
||
Assignee | ||
Comment 35•6 years ago
|
||
Assignee | ||
Comment 36•6 years ago
|
||
Assignee | ||
Comment 37•6 years ago
|
||
Assignee | ||
Comment 38•6 years ago
|
||
Assignee | ||
Comment 39•6 years ago
|
||
Assignee | ||
Comment 40•6 years ago
|
||
Assignee | ||
Comment 41•6 years ago
|
||
Assignee | ||
Comment 42•6 years ago
|
||
Assignee | ||
Comment 43•6 years ago
|
||
Assignee | ||
Comment 44•6 years ago
|
||
Assignee | ||
Comment 45•6 years ago
|
||
Assignee | ||
Comment 46•6 years ago
|
||
Assignee | ||
Comment 47•6 years ago
|
||
Assignee | ||
Comment 48•6 years ago
|
||
Assignee | ||
Comment 49•6 years ago
|
||
Assignee | ||
Comment 50•6 years ago
|
||
Assignee | ||
Comment 51•6 years ago
|
||
Assignee | ||
Comment 52•6 years ago
|
||
Assignee | ||
Comment 53•6 years ago
|
||
Assignee | ||
Comment 54•6 years ago
|
||
Assignee | ||
Comment 55•6 years ago
|
||
Assignee | ||
Comment 56•6 years ago
|
||
Assignee | ||
Comment 57•6 years ago
|
||
Assignee | ||
Comment 58•6 years ago
|
||
Assignee | ||
Comment 59•6 years ago
|
||
Assignee | ||
Comment 60•6 years ago
|
||
Assignee | ||
Comment 61•6 years ago
|
||
Assignee | ||
Comment 62•6 years ago
|
||
Assignee | ||
Comment 63•6 years ago
|
||
Assignee | ||
Comment 64•6 years ago
|
||
Assignee | ||
Comment 65•6 years ago
|
||
With most of the JS components converted to static registration, the string
arena and component hashtables are much smaller than the minimum space we
allocate for them.
Comment 66•6 years ago
|
||
That's going to break adding JS components when doing artifact builds, isn't it?
Assignee | ||
Comment 67•6 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #66)
That's going to break adding JS components when doing artifact builds, isn't it?
No, it will only break adding static registrations for JS components. Other forms of registration are still supported for now. But I'd generally like to discourage people from adding new JS components for things that aren't tied to C++ in any case.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 68•6 years ago
|
||
Assignee | ||
Comment 69•6 years ago
|
||
Comment 70•6 years ago
|
||
Assignee | ||
Comment 71•6 years ago
|
||
Comment 72•6 years ago
|
||
Backed out 2 changesets (bug 1524688) for build bustages at build/src/obj-firefox/xpcom/components/StaticComponents.cpp
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/1a199fcf0ef6e0c7b106e1820e8fb12c08e2dbab
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228509342&repo=mozilla-inbound&lineNumber=13421
task 2019-02-14T22:50:40.929Z] 22:50:40 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/strres'
[task 2019-02-14T22:50:40.990Z] 22:50:40 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/strres'
[task 2019-02-14T22:50:40.990Z] 22:50:40 INFO - intl/strres/Unified_cpp_intl_strres0.o
[task 2019-02-14T22:50:40.990Z] 22:50:40 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/strres'
[task 2019-02-14T22:50:41.051Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-02-14T22:50:41.055Z] 22:50:41 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o Unified_cpp_xpcom_threads1.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/xpcom/threads -I/builds/worker/workspace/build/src/obj-firefox/xpcom/threads -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/caps -I/builds/worker/workspace/build/src/tools/profiler -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/Unified_cpp_xpcom_threads1.o.pp /builds/worker/workspace/build/src/obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads1.cpp
[task 2019-02-14T22:50:41.055Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-02-14T22:50:41.071Z] 22:50:41 INFO - make[4]: Nothing to be done for 'target'.
[task 2019-02-14T22:50:41.112Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/unicharutil/util'
[task 2019-02-14T22:50:41.112Z] 22:50:41 INFO - mkdir -p '.deps/'
[task 2019-02-14T22:50:41.112Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/unicharutil/util'
[task 2019-02-14T22:50:41.133Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/locale/tests/gtest'
[task 2019-02-14T22:50:41.133Z] 22:50:41 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o Unified_cpp_locale_tests_gtest0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/intl/locale/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/intl/locale/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/Unified_cpp_locale_tests_gtest0.o.pp /builds/worker/workspace/build/src/obj-firefox/intl/locale/tests/gtest/Unified_cpp_locale_tests_gtest0.cpp
[task 2019-02-14T22:50:41.133Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/locale/tests/gtest'
[task 2019-02-14T22:50:41.154Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/unicharutil/util'
[task 2019-02-14T22:50:41.154Z] 22:50:41 INFO - intl/unicharutil/util/Unified_cpp_unicharutil_util0.o
[task 2019-02-14T22:50:41.154Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/unicharutil/util'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/l10n'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - mkdir -p '.deps/'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/l10n'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/l10n'
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - intl/l10n/Unified_cpp_intl_l10n0.o
[task 2019-02-14T22:50:41.163Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/l10n'
[task 2019-02-14T22:50:41.546Z] 22:50:41 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/components'
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o StaticComponents.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/xpcom/components -I/builds/worker/workspace/build/src/obj-firefox/xpcom/components -I/builds/worker/workspace/build/src/obj-firefox/xpcom -I/builds/worker/workspace/build/src/xpcom/base -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/xpcom/ds -I/builds/worker/workspace/build/src/chrome -I/builds/worker/workspace/build/src/js/xpconnect/loader -I/builds/worker/workspace/build/src/layout/build -I/builds/worker/workspace/build/src/modules/libjar -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -MD -MP -MF .deps/StaticComponents.o.pp /builds/worker/workspace/build/src/obj-firefox/xpcom/components/StaticComponents.cpp
[task 2019-02-14T22:50:41.547Z] 22:50:41 ERROR - /builds/worker/workspace/build/src/obj-firefox/xpcom/components/StaticComponents.cpp:5718:47: error: no matching function for call to 'ArrayLengthHelper'
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - auto jsms = MakeUnique<nsTArray<nsCString>>(MOZ_ARRAY_LENGTH(gComponentJSMs));
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:179:12: note: expanded from macro 'MOZ_ARRAY_LENGTH'
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - sizeof(mozilla::detail::ArrayLengthHelper(array))
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2019-02-14T22:50:41.547Z] 22:50:41 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:164:8: note: candidate template ignored: substitution failure [with T = const mozilla::xpcom::StringOffset, N = 0]: zero-length arrays are not permitted in C++
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - char (&ArrayLengthHelper(T (&array)[N]))[N];
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - ^ ~
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - 1 error generated.
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - /builds/worker/workspace/build/src/config/rules.mk:812: recipe for target 'StaticComponents.o' failed
[task 2019-02-14T22:50:41.552Z] 22:50:41 ERROR - make[4]: *** [StaticComponents.o] Error 1
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/components'
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'xpcom/components/target' failed
[task 2019-02-14T22:50:41.552Z] 22:50:41 ERROR - make[3]: *** [xpcom/components/target] Error 2
[task 2019-02-14T22:50:41.552Z] 22:50:41 INFO - make[3]: *** Waiting for unfinished jobs....
Assignee | ||
Comment 73•6 years ago
|
||
Assignee | ||
Comment 74•6 years ago
|
||
Comment 75•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3c2617631c8c
https://hg.mozilla.org/mozilla-central/rev/df8ab98551c1
https://hg.mozilla.org/mozilla-central/rev/91616590f2cd
https://hg.mozilla.org/mozilla-central/rev/c887c1baca24
https://hg.mozilla.org/mozilla-central/rev/c6130519c7cc
https://hg.mozilla.org/mozilla-central/rev/d9afb8bdd3af
https://hg.mozilla.org/mozilla-central/rev/b53e94682c7d
https://hg.mozilla.org/mozilla-central/rev/c787c503e7cc
https://hg.mozilla.org/mozilla-central/rev/39fdb923b0f1
https://hg.mozilla.org/mozilla-central/rev/7dfbef2f4d9e
https://hg.mozilla.org/mozilla-central/rev/b1dfd8a76cf1
https://hg.mozilla.org/mozilla-central/rev/165bdb5717f3
https://hg.mozilla.org/mozilla-central/rev/3d7060d92f90
https://hg.mozilla.org/mozilla-central/rev/5e00a19796e9
https://hg.mozilla.org/mozilla-central/rev/42d8d20de831
https://hg.mozilla.org/mozilla-central/rev/72bba92c04be
https://hg.mozilla.org/mozilla-central/rev/97970d276725
https://hg.mozilla.org/mozilla-central/rev/2c74368a599d
https://hg.mozilla.org/mozilla-central/rev/f7bd60e66927
https://hg.mozilla.org/mozilla-central/rev/c92b9ee33de7
https://hg.mozilla.org/mozilla-central/rev/258ee5ceb51f
https://hg.mozilla.org/mozilla-central/rev/180b98f7073f
https://hg.mozilla.org/mozilla-central/rev/d385ebcb283f
https://hg.mozilla.org/mozilla-central/rev/cd87fc8903f7
https://hg.mozilla.org/mozilla-central/rev/1d60cf9b2047
https://hg.mozilla.org/mozilla-central/rev/cac8dcbeb883
https://hg.mozilla.org/mozilla-central/rev/301339492394
https://hg.mozilla.org/mozilla-central/rev/27da2eea89f1
https://hg.mozilla.org/mozilla-central/rev/9845f8c1a4e5
https://hg.mozilla.org/mozilla-central/rev/4e4440d26242
https://hg.mozilla.org/mozilla-central/rev/142bfed3ea38
https://hg.mozilla.org/mozilla-central/rev/f86c8798847e
https://hg.mozilla.org/mozilla-central/rev/ea73c355d08c
https://hg.mozilla.org/mozilla-central/rev/ad0168bf0506
https://hg.mozilla.org/mozilla-central/rev/8dd9f80c2e02
https://hg.mozilla.org/mozilla-central/rev/57fc958412b6
https://hg.mozilla.org/mozilla-central/rev/f06fc063811c
https://hg.mozilla.org/mozilla-central/rev/e1708f3e9990
https://hg.mozilla.org/mozilla-central/rev/4c6bf381fc8a
https://hg.mozilla.org/mozilla-central/rev/785f158f7ec3
https://hg.mozilla.org/mozilla-central/rev/e095356d248f
https://hg.mozilla.org/mozilla-central/rev/6949d8a480a7
https://hg.mozilla.org/mozilla-central/rev/397ce6923d23
https://hg.mozilla.org/mozilla-central/rev/254429537792
https://hg.mozilla.org/mozilla-central/rev/ac097acb51f7
https://hg.mozilla.org/mozilla-central/rev/27ba0320a22e
https://hg.mozilla.org/mozilla-central/rev/83bacdb5fa9d
https://hg.mozilla.org/mozilla-central/rev/844dce347667
https://hg.mozilla.org/mozilla-central/rev/c1fd1a4cd1a2
https://hg.mozilla.org/mozilla-central/rev/b8b0ce631921
https://hg.mozilla.org/mozilla-central/rev/f63175b13c16
https://hg.mozilla.org/mozilla-central/rev/2cb7f117c386
https://hg.mozilla.org/mozilla-central/rev/e99e560806dd
https://hg.mozilla.org/mozilla-central/rev/48e1be308f3a
https://hg.mozilla.org/mozilla-central/rev/e13a97f2f4ba
https://hg.mozilla.org/mozilla-central/rev/c23fdd4bfb72
https://hg.mozilla.org/mozilla-central/rev/6c9e064daea6
https://hg.mozilla.org/mozilla-central/rev/d40113ddd74d
https://hg.mozilla.org/mozilla-central/rev/4816d23cb8eb
https://hg.mozilla.org/mozilla-central/rev/8276ffc51b70
https://hg.mozilla.org/mozilla-central/rev/603593d5501b
https://hg.mozilla.org/mozilla-central/rev/4d3fbd27d326
https://hg.mozilla.org/mozilla-central/rev/c999e7890f8b
https://hg.mozilla.org/mozilla-central/rev/149562860c06
Comment 76•6 years ago
|
||
Comment 77•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 78•6 years ago
|
||
Comment 79•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/280ea49c019b
https://hg.mozilla.org/mozilla-central/rev/f8fb6e47bb24
Comment 80•6 years ago
|
||
Updated•2 years ago
|
Description
•