Closed
Bug 1524957
Opened 6 years ago
Closed 6 years ago
Prevent autocomplete suggestions from other pages in the search field
Categories
(Toolkit :: Preferences, enhancement, P1)
Toolkit
Preferences
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: valentin, Assigned: Paolo)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
I typed net - for network - and got a suggestion for planet of the apes :) I think I typed that in IMDb or some other search engine at some point.
IMO we should only autocomplete pref names (and maybe values)
Assignee | ||
Comment 1•6 years ago
|
||
Thanks, maybe you typed this in another browser window field at some point in the past.
Probably, using a more unique ID for the search field will prevent this from happening again. This page, like the old one, doesn't use a form submit, and I believe new autocomplete results cannot be collected from this page.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: Restrict autocomplete to preference names or values → Prevent autocomplete suggestions from other pages in the search field
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D18563
Assignee | ||
Comment 4•6 years ago
|
||
I just attached part 1 to this bug since I was planning to do this refactoring anyways.
Assignee | ||
Comment 5•6 years ago
|
||
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/25da97984105
Part 1 - Move the main content to a template. r=bgrins
https://hg.mozilla.org/integration/mozilla-inbound/rev/a274c156b2d4
Part 2 - Prevent autocomplete suggestions from other pages in the search field. r=bgrins
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/25da97984105
https://hg.mozilla.org/mozilla-central/rev/a274c156b2d4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•