Closed
Bug 1525041
Opened 6 years ago
Closed 6 years ago
./mach bootstrap should not try to use/get `rustup` when using artifact builds
Categories
(Firefox Build System :: Bootstrap Configuration, enhancement)
Firefox Build System
Bootstrap Configuration
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: Gijs, Assigned: froydnj)
Details
Attachments
(1 file)
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
As per topic.
- vanilla machine, download m-c, run ./mach bootstrap
- pick 'firefox for desktop artifact builds'
ER:
doesn't attempt to install/upgrade rust
AR:
attempts to install/upgrade rust.
Commenting out https://searchfox.org/mozilla-central/rev/152993fa346c8fd9296e4cd6622234a664f53341/python/mozboot/mozboot/bootstrap.py#444 seems to help.
Assignee | ||
Comment 1•6 years ago
|
||
This is the "official" way to comment this call out.
Attachment #9041204 -
Flags: review?(gijskruitbosch+bugs)
Reporter | ||
Comment 2•6 years ago
|
||
Comment on attachment 9041204 [details] [diff] [review]
avoid downloading rust packages when bootstrapping for artifact builds
Thanks!
Attachment #9041204 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ebaff11acf7
avoid downloading rust packages when bootstrapping for artifact builds; r=Gijs
Comment 4•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Updated•6 years ago
|
Assignee: nobody → nfroyd
You need to log in
before you can comment on or make changes to this bug.
Description
•