Closed Bug 1525269 Opened 6 years ago Closed 6 years ago

Implement UrlbarView::selectedIndex

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

search-one-offs.js reads and writes popup.selectedIndex a bunch of times. UrlbarView doesn't currently have a selectedIndex property.

No longer blocks: 1491248
Depends on: 1491248

Does it make sense to have selectedIndex? Suppose that we have 2 groups of results side by side, one on the left and one on the right, and one-off buttons below or above everything... what is selectedIndex in that case?

Note, we could also keep the concept of selectedIndex and consider side by side groups as a continuation, so the first group is 1-10, the second one is 11-20... and so on. One-off buttons would also be a group by themselves and have their selectedIndex.
The only problematic case may be LTR vs RTL if the groups are inverted horizontally.

Note: browser_urlbarOneOffs_settings.js is ported but currently has test_open_settings_with_enter turned off, so we should look to enable that here when we implement/resolve this.

Blocks: 1499648
Blocks: 1526815
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P2 → P1
Blocks: 1525318
Blocks: 1527260
No longer blocks: 1526815
Summary: Implement UrlbarView::selectedIndex or equivalent for one-off search button support → Implement UrlbarView::selectedIndex
Blocks: 1524561
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99ec4f94c2fe Implement UrlbarView::selectedIndex. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Depends on: 1527724
Regressions: 1527724
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: