Implement UrlbarView::selectedIndex
Categories
(Firefox :: Address Bar, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
search-one-offs.js reads and writes popup.selectedIndex a bunch of times. UrlbarView doesn't currently have a selectedIndex property.
Comment 1•6 years ago
|
||
It would be good if we could update UrlbarTestUtils to use this as well:
Assignee | ||
Updated•6 years ago
|
Comment 2•6 years ago
|
||
Does it make sense to have selectedIndex? Suppose that we have 2 groups of results side by side, one on the left and one on the right, and one-off buttons below or above everything... what is selectedIndex in that case?
Comment 3•6 years ago
|
||
Note, we could also keep the concept of selectedIndex and consider side by side groups as a continuation, so the first group is 1-10, the second one is 11-20... and so on. One-off buttons would also be a group by themselves and have their selectedIndex.
The only problematic case may be LTR vs RTL if the groups are inverted horizontally.
Comment 4•6 years ago
|
||
Note: browser_urlbarOneOffs_settings.js is ported but currently has test_open_settings_with_enter
turned off, so we should look to enable that here when we implement/resolve this.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 7•6 years ago
|
||
bugherder |
Description
•