Closed Bug 1525362 Opened 6 years ago Closed 3 years ago

[10.14] macOS system dark UI not used

Categories

(Core :: Widget: Cocoa, defect, P3)

65 Branch
Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: theoverlordodin, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Select Dark Appearance in macOS Mojave system preferences.

Actual results:

Several Firefox windows and all window title bars continue to use the light system UI.

Expected results:

Many of Firefox's UI elements that use macOS system UI should now appear in dark mode. These include window title bars, as well as the entire windows for Library and Print.

Moving in to a better component.

Component: Untriaged → Widget: Cocoa
Product: Firefox → Core
Blocks: mojave
OS: Unspecified → macOS
Priority: -- → P3
Depends on: 1623686

Isn't this resolved in 91.0a1 (2021-06-01) (64-Bit)

  • title bars: dark
  • download window: dark

Should this be closed as fixed?

Attached image download window dark mode.png (deleted) —

(In reply to steve from comment #3)

Isn't this resolved in 91.0a1 (2021-06-01) (64-Bit)

  • title bars: dark
  • download window: dark

Should this be closed as fixed?

Please check:
https://bugzilla.mozilla.org/show_bug.cgi?id=1623686

Dark theme seems to be far from fixed.

So this bug here is for general dark mode on macOS? If so, the title should be updated. Which exact elements are missing dark mode currently that are tracked in this bug here?

(In reply to steve from comment #7)

So this bug here is for general dark mode on macOS? If so, the title should be updated. Which exact elements are missing dark mode currently that are tracked in this bug here?

Hm, this bug was marked as dependent on the one I linked, so I think it's best to let it be for now and wait until that one is fixed first.
Then this one can be reviewed and see if there's still things needing a fix.

This is fixed now that bug 1623686 is resolved. Please file new bugs blocking bug 1623686 if you notice other windows that don't have a dark appearance.

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: