Scroll position persists after clicking on a link
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox65 unaffected, firefox66 unaffected, firefox67 verified)
Tracking | Status | |
---|---|---|
firefox65 | --- | unaffected |
firefox66 | --- | unaffected |
firefox67 | --- | verified |
People
(Reporter: csheany, Assigned: botond)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Android 7.1.1; Tablet; rv:67.0) Gecko/67.0 Firefox/67.0
Steps to reproduce:
- Open https://github.com/mozilla-mobile/focus-android
- Request desktop site
- Tap Commits
- Scroll to the bottom
- Tap Older
Actual results:
The bottom of the page is in view
Expected results:
The top of the page is in view
Assignee | ||
Comment 1•6 years ago
|
||
Regression compared to Firefox 65.
Assignee | ||
Comment 2•6 years ago
|
||
Mozregression points to bug 1520077:
It's not immediately clear how that change could cause this.
Assignee | ||
Updated•6 years ago
|
Comment 3•6 years ago
|
||
I can't reproduce at all on my Android phone.
Assignee | ||
Comment 4•6 years ago
|
||
I was testing on a tablet. I just tried on a phone, and I can't repro there either. Guess it's tablet-specific.
Comment 5•6 years ago
|
||
I couldn't reproduce this issue on the latest Nightly build 67.0a1 with a Google Pixel 3 XL (Android P) and Sony Xperia Z5(Android 7.0).
Every time when I tapped on the older
the top page was in view. I tried to reproduce this while the web page was zoomed in but with not so much success.
Can you please mention the exact device, android version and firefox version that are you using while reproducing this issue.
Thank you for looking into it. The device is a Samsung Galaxy Tab A.
I am using the latest Nightly.
As Botond mentioned, only tablets might be affected.
Comment 7•6 years ago
|
||
Hi,
I was able to reproduce the issue with a Samsung Galaxy Tab S3, on Firefox 65.0.1, and Beta 66.0b7.
But I was not able to reproduce it on the latest Nightly 67.0a1 (2019-02-12).
I will confirm the issue.
Thanks for the report!
Comment 8•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
I think comment 7 may be confusing the "good" and "bad" outcomes.
The scroll position being at the top of the new page, which happens in 65 and 66, is the "good" outcome. The scroll position being near the bottom of the new page, which happens in nightly, is the "bad" outcome.
It's a bit confusing because if navigation does not occur, you expect the scroll position to be preserved. If navigation does occur (as in these STR), you expect the scroll position to be at the beginning of the new page.
Comment 11•6 years ago
|
||
I'll go with that, thanks :)
Updated•6 years ago
|
Comment 13•6 years ago
|
||
I suppose we still want to fix this in 67.
Anyway, I thought I can reproduce the issue on RDM with specifying 'Nexus 10' there (and enabling apz.allow_zooming pref). But the issue I can see is also reproducible without disabling the minimum scale change. So the issue I am seeing might be a different issue.
I also tried on Android emulator with tablet mode (I believe it's tablet mode, I am using 1280x800 resolution), but I can't reproduce it yet.
Comment 14•6 years ago
|
||
Thank you Botond, I was misguided by the "good" and "bad" outcome.
I rectify Comment 7, the issue is reproducible only in Nightly 67.0a1.
Thank you, Ryan, for changing the flags.
I`m sorry for the confusion.
Assignee | ||
Comment 15•6 years ago
|
||
Let's park this bug with me as I'm able to reproduce it. I will investigate when I get a chance.
Assignee | ||
Comment 16•6 years ago
|
||
The issue here is related to the layout viewport being larger than it should be on this page. The layout viewport size should match the visual viewport size when the page is at its minimum zoom, but on this page it's taller, tall enough to include the entire content size.
Assignee | ||
Comment 17•6 years ago
|
||
I have a fix for this locally. I would like to write a test as well.
Assignee | ||
Comment 18•6 years ago
|
||
Assignee | ||
Comment 19•6 years ago
|
||
Depends on D19995
Assignee | ||
Comment 20•6 years ago
|
||
Depends on D19996
Assignee | ||
Comment 21•6 years ago
|
||
Updated•6 years ago
|
Comment 22•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d3ca8862f6ff
https://hg.mozilla.org/mozilla-central/rev/bf8ca7933ead
Comment 23•6 years ago
|
||
Verified as fixed on latest Nightly build (67.0a1) with Samsung Galaxy Tab S3 (affected device).
Updated•4 years ago
|
Description
•