Closed
Bug 1526051
Opened 6 years ago
Closed 6 years ago
History tagged results should be returned by the Quantum Bar even if bookmarks are filtered out
Categories
(Firefox :: Address Bar, enhancement, P3)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: standard8, Assigned: mak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In porting browser_autocomplete_tag_star_visibility.js to QuantumBar, I noticed it is failing when browser.urlbar.suggest.bookmark is false.
It should be returning a result for a tagged item regardless of the pref setting, but it is not.
|
Assignee | |
Comment 1•6 years ago
|
||
hm, I wonder if we want that or not, originally we could tag bookmarks or history, but now we only allow to tag bookmarks.
|
|
Assignee | |
Comment 2•6 years ago
|
||
yeah, I think I'll just change the test to expect a different behavior, we should not be showing or returning tags if bookmarks are not suggested.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•6 years ago
|
||
Hm, but the added urls also have visits, so maybe the test is not wrong. Those results should be returned because the word matches on title/url, but not presented as a bookmark or a tag...
|
|
Assignee | |
Updated•6 years ago
|
Summary: QuantumBar: Allow searching for a tag even when browser.urlbar.suggest.bookmark is false → History tagged results should be returned by the Quantum Bar even if bookmarks are filtered out
|
|
Assignee | |
Comment 4•6 years ago
|
||
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/f8f4200ccbb9
History tagged results should be returned by the Quantum Bar even if bookmarks are filtered out. r=adw
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.
Description
•