Closed Bug 1526379 Opened 6 years ago Closed 6 years ago

[ja] In-content Clear All History dialog isn't wide enough in Japanese locale

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Version:
67 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- verified

People

(Reporter: nolamiller1203+bugzilla, Assigned: ntim)

References

Details

(Keywords: regression)

Attachments

(4 files)

dialog.png
(deleted), image/png
Details
ok20190205215922.png
(deleted), image/png
Details
Bug 1526379 - Use <vbox> instead of <box> to make the children stretch horizontally in sanitize dialogs. r=Gijs
(deleted), text/x-phabricator-request
Details
fixed.jpg
(deleted), image/jpeg
Details
Attached image dialog.png (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Options -> Privacy & Security -> Clear History

Actual results:

A decent dialog appeared.

Expected results:

Lack of right side of the option dialog on 'ja' language pack
Concerned with https://bugzilla.mozilla.org/show_bug.cgi?id=1523696

Severity: normal → trivial
Component: Untriaged → Preferences
Summary: Lack of right side of the option dialog on 'ja' language pack → [ja] In-content Clear All History dialog isn't wide enough in Japanese locale
Blocks: 1523696, 1514652
Attached image ok20190205215922.png (deleted) —

It was OK on Nightyly 67.0a1 (2019-02-05) build id: 20190205215922, 'ja' locale.

Interesting... would be curious to know what broke this.

Keywords: regression, regressionwindow-wanted

Please ignore comment#3.

Correct regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=476293c6700fb45da40b8096184211432a89be57&tochange=3a3e393396f418df1490aa0832d0c54fc353d522

Suspect:
d599d1a73a3a Tim Nguyen — Bug 1525747 - Remove XUL grid layout from browser/components/preferences/sanitize.xul. r=Gijs

Blocks: 1525747
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regressionwindow-wanted

:ntim, please take a look.

Flags: needinfo?(ntim.bugs)

Gijs, thanks.

It can't be bug 1525747 since that's a different dialog (though it may also be affected by this issue), bug 1525739 is more likely.

Blocks: 1525739
No longer blocks: 1525747
Has Regression Range: --- → yes
Has STR: --- → yes
Priority: -- → P1
Assignee: nobody → ntim.bugs
Flags: needinfo?(ntim.bugs)

The issue here was that I used <box> instead of <vbox> for the second section of the dialog. Since XUL flex layouts have -moz-box-align: stretch, this makes a difference, because <vbox> will make the child checkbox stretch horizontally instead of vertically like <box> does. The horizontal stretching restricts the checkbox dimension and forces the checkbox to wrap its content.

Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b08ce769c436 Use <vbox> instead of <box> to make the children stretch horizontally in sanitize dialogs. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/b08ce769c436

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Walter or Alice, could you please verify the issue is gone for you in latest nightly? Thank you.

Flags: needinfo?(nolamiller1203+bugzilla)
Flags: needinfo?(alice0775)
Attached image fixed.jpg (deleted) —

I have confirmed it's fixed. Thank you for fixing!
Nightly 67.0a1 (2019-02-18) build id 20190218214558

Flags: needinfo?(nolamiller1203+bugzilla)
Flags: needinfo?(alice0775)

Thanks!

Status: RESOLVED → VERIFIED
status-firefox67: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: