Closed
Bug 1526452
Opened 6 years ago
Closed 6 years ago
Stop committing Activity Stream source maps to mozilla-central
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | unaffected |
firefox67 | --- | fixed |
People
(Reporter: k88hudson, Assigned: k88hudson)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
I'd like to propose no longer committing source maps for our bundled CSS / JS files in MC.
We can continue to support this for local dev (via startmc perhaps), but removing them from our exports will:
- Make exports easier to read
- Drastically reduce the chance of merge conflicts between uplifts/exports
The downside of this is that we'll no longer have as fine-grained line numbers from debugging directly in nightly etc., but I'd argue that most of our development happens locally anyway and our bundled files are readable enough that we'd still be able to track down a compiled line-number if we needed to.
Assignee | ||
Updated•6 years ago
|
Summary: Stop committing Activity Stream source maps in MC → Stop committing Activity Stream source maps to MC
Assignee | ||
Updated•6 years ago
|
Summary: Stop committing Activity Stream source maps to MC → Stop committing Activity Stream source maps to mozilla-central
Updated•6 years ago
|
Assignee: nobody → khudson
Iteration: --- → 67.2 - Feb 11 - 24
status-firefox66:
--- → unaffected
Priority: -- → P1
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Severity: normal → enhancement
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Keywords: github-merged
Comment 2•6 years ago
|
||
As a side note, beta+ users opening devtools on about:newtab will no longer see:
Source map error: TypeError: NetworkError when attempting to fetch resource.
Resource URL: resource://activity-stream/data/content/activity-stream.bundle.js
Source map error: TypeError: NetworkError when attempting to fetch resource.
Resource URL: resource://activity-stream/css/activity-stream.css
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•