Closed Bug 1526452 Opened 6 years ago Closed 6 years ago

Stop committing Activity Stream source maps to mozilla-central

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Iteration:
67.2 - Feb 11 - 24
Tracking Flags:
Tracking Status
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: k88hudson, Assigned: k88hudson)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4783
(deleted), text/x-github-pull-request
Details

I'd like to propose no longer committing source maps for our bundled CSS / JS files in MC.

We can continue to support this for local dev (via startmc perhaps), but removing them from our exports will:

  • Make exports easier to read
  • Drastically reduce the chance of merge conflicts between uplifts/exports

The downside of this is that we'll no longer have as fine-grained line numbers from debugging directly in nightly etc., but I'd argue that most of our development happens locally anyway and our bundled files are readable enough that we'd still be able to track down a compiled line-number if we needed to.

Summary: Stop committing Activity Stream source maps in MC → Stop committing Activity Stream source maps to MC
Summary: Stop committing Activity Stream source maps to MC → Stop committing Activity Stream source maps to mozilla-central
Assignee: nobody → khudson
Iteration: --- → 67.2 - Feb 11 - 24
status-firefox66: --- → unaffected
Priority: -- → P1

  

  



    
  
Severity: normal → enhancement

    
  
Keywords: github-merged

    
  
Blocks: 1529755

    
    

    
  
As a side note, beta+ users opening devtools on about:newtab will no longer see:


Source map error: TypeError: NetworkError when attempting to fetch resource.
Resource URL: resource://activity-stream/data/content/activity-stream.bundle.js

Source map error: TypeError: NetworkError when attempting to fetch resource.
Resource URL: resource://activity-stream/css/activity-stream.css




  

  



    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f98b2b564191



  

  



          status-firefox67:
          --- → fixed
Target Milestone: --- → Firefox 67

    
  
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Activity Streams: Newtab → New Tab Page

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: