border-style is not drawn with double
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox65 | --- | wontfix |
| firefox66 | --- | fixed |
| firefox67 | --- | fixed |
People
(Reporter: ayakawa.m, Assigned: gw)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(3 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/plain
|
Details | |
|
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
borderdouble.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
Steps to reproduce:
access http://ayakawa.o.oo7.jp/borderdouble.html
Actual results:
border-style double is not drawn with double.
Expected results:
border-style is drawn with double.
|
Reporter | |
Updated•6 years ago
|
|
|
Reporter | |
Comment 1•6 years ago
|
||
GOOD 2019-02-07 build
BAD 2019-02-08 build
|
||
Updated•6 years ago
|
|
|
||
Comment 2•6 years ago
|
||
Takeshi, could you please attach a results of about:support (Help – Troubleshooting Information)?
|
|
Reporter | |
Comment 3•6 years ago
|
||
|
|
||
Comment 4•6 years ago
|
||
Yesterday(2019-02-08), WebRender became default enabled on some AMD and Intel GPU.
Bug 1525929. Turn on WebRender on AMD Southern Islands
Bug 1525128. Turn on WebRender by default on desktop Haswell
Regression Window(with force enabled WebRender):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d08944831e26fc9ec613e1fa2dc35d00332586ac&tochange=5b15326286d466b5cf4889160cc09b59bdde08fd
Regressed by: Bug 1465058
|
||
Updated•6 years ago
|
|
Assignee | |
Comment 5•6 years ago
|
||
The WR double style border shader has a condition to check if the
widths of the edges are too small to apply the style, in which case
it draws the border segment as solid. However, the check was
incorrectly skipping when the width of the inner / outer edge
was exactly one pixel.
|
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
|
||
Comment 8•6 years ago
|
||
Is this something we should consider backporting to Beta? It grafts cleanly.
|
|
||
Comment 9•6 years ago
|
||
Comment on attachment 9043127 [details]
Bug 1526504 - border-style is not drawn with double
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
None
User impact if declined
Borders will be drawn incorrectly when WebRender is enabled
Is this code covered by automated tests?
Yes
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
No
If yes, steps to reproduce
List of other uplifts needed
None
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
This is a WebRender only change. It doesn't touch code that is run unless WebRender is enabled.
String changes made/needed
|
|
||
Updated•6 years ago
|
Comment on attachment 9043127 [details]
Bug 1526504 - border-style is not drawn with double
Webrender fix, adds tests.
Let's uplift for beta 8 so the WR experiments will be that much more awesome.
|
||
Comment 11•6 years ago
|
||
| bugherder uplift | ||
Description
•