Closed Bug 1526818 Opened 6 years ago Closed 5 years ago

QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: standard8, Assigned: okonaraddi)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file, 2 obsolete files)

Bug 1526818 - QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils
(deleted), text/x-phabricator-request
Details

We've a few places where we're creating and using a autocomplete.properties, it would seem to make sense to expose this as a single instance via UrlbarUtils.

Type: enhancement → task
Assignee: nobody → okonaraddi
Status: NEW → ASSIGNED
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/421f9e16c210 QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils r=adw
Backout by dvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fcd42bba4295 Backed out changeset 421f9e16c210 for linting failure at /builds/worker/checkouts/gecko/browser/components/urlbar/UrlbarProviderUnifiedComplete.jsm on a CLOSED TREE

Backed out changeset 421f9e16c210 (Bug 1526818) for linting failure at /builds/worker/checkouts/gecko/browser/components/urlbar/UrlbarProviderUnifiedComplete.jsm

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=250049873&revision=421f9e16c210ce04a472be4ad9ad2a447f100a77

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250063389&repo=autoland&lineNumber=289

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=250049873&searchStr=es&revision=fcd42bba429590de1b36736ae07a1525195cc1f4

[task 2019-06-05T00:38:26.703Z] Also creating executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python
[task 2019-06-05T00:38:28.431Z] Installing setuptools, pip, wheel...done.
[task 2019-06-05T00:38:29.498Z] running build_ext
[task 2019-06-05T00:38:29.498Z] building 'psutil._psutil_linux' extension
[task 2019-06-05T00:38:29.498Z] creating build
[task 2019-06-05T00:38:29.498Z] creating build/temp.linux-x86_64-2.7
[task 2019-06-05T00:38:29.498Z] creating build/temp.linux-x86_64-2.7/psutil
[task 2019-06-05T00:38:29.498Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-06-05T00:38:29.498Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-06-05T00:38:29.498Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o
[task 2019-06-05T00:38:29.498Z] creating build/lib.linux-x86_64-2.7
[task 2019-06-05T00:38:29.498Z] creating build/lib.linux-x86_64-2.7/psutil
[task 2019-06-05T00:38:29.498Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so
[task 2019-06-05T00:38:29.498Z] building 'psutil._psutil_posix' extension
[task 2019-06-05T00:38:29.498Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-06-05T00:38:29.498Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-06-05T00:38:29.498Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-06-05T00:38:29.498Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-06-05T00:38:29.498Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-06-05T00:38:29.498Z] 
[task 2019-06-05T00:38:29.498Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-06-05T00:47:21.844Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/urlbar/UrlbarProviderUnifiedComplete.jsm:16:1 | 'Services' is defined but never used. (no-unused-vars)
[task 2019-06-05T00:47:21.844Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/urlbar/UrlbarView.jsm:10:1 | 'Services' is defined but never used. (no-unused-vars)
[taskcluster 2019-06-05 00:47:22.183Z] === Task Finished ===
[taskcluster 2019-06-05 00:47:22.946Z] Unsuccessful task run with exit code: 1 completed in 939.675 seconds
Flags: needinfo?(okonaraddi)

I would recommend that we hold off landing this until after quantumbar has shipped, to avoid potential conflicts with other uplifts.

status-firefox68: --- → wontfix
status-firefox69: --- → wontfix
Target Milestone: --- → Future
Flags: needinfo?(okonaraddi)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:okonaraddi, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(okonaraddi)

I wontfix'd this bug for 69.

Depends on: quantumbar-release
Flags: needinfo?(okonaraddi)
Attachment #9069815 - Attachment is obsolete: true
Attachment #9074581 - Attachment is obsolete: true

I tried to land this through Lando but it failed with "abort: uncommitted changes"...

(In reply to Dão Gottwald [::dao] from comment #10)

I tried to land this through Lando but it failed with "abort: uncommitted changes"...

Discussion in bug 1558973 implies that this means it needs a rebase.

Attachment #9074626 - Attachment description: Bug 1526818 - QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils r=adw! → Bug 1526818 - QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils
Pushed by okonaraddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26853a62fed3 QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils r=adw
Pushed by okonaraddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/284d6fb99eb3 QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils r=adw

Sorry about that, fixed in most recent push

Flags: needinfo?(okonaraddi)

https://hg.mozilla.org/mozilla-central/rev/284d6fb99eb3

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: Future → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: