Display message in nightly about dark theme is not working as expected
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | unaffected |
firefox67 | --- | unaffected |
People
(Reporter: bnagabandi, Unassigned)
References
Details
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-02-10)
OS : Mac and Windows 10 Pro
Depends on bug : https://bugzilla.mozilla.org/show_bug.cgi?id=1524021
Observations:
I have tried Got it
scenario on Mac OS and Use older version
scenario on Windows 10 Pro respectively
Mac OS :
-
After
Dark Theme
is enabled viaabout:addons
, New Tab shows the messageThis version of New Tab doesn't support dark mode yet.
(As of nowDiscoverystream.config
pref value hasTrue
as default value) -
When user clicks on
Got it
button, New Tab doesn't open inDark Mode
-
If the pref has been set to
False
, New Tab still doesn't open inDark Mode
-
Tried disabling
Dark Theme
viaabout:addons
to re-test to see message, but message is not displayed (is this expected, not showing the message multiple times to user? or is this caching issue?)
QA Recording:
https://www.dropbox.com/s/8dqi3xa09aivqs1/QA%20Rec%20%28%3F%3F%29%20-%20Bug%201524021.mp4?dl=0
Windows 10 Pro :
- After
Dark Theme
is enabled viaabout:addons
, New Tab shows the messageThis version of New Tab doesn't support dark mode yet.
(As of nowDiscoverystream.config
pref value hasTrue
as default value) - When user clicks on
Use older version
button, New Tab opens inDark Mode
- If the pref has been set to
False
, New Tab still opens inDark Mode
, unable to get rid ofDark Mode
with pref changes, but defaults back to normal only whenDark Theme
isdisabled
viaabout:addons
(is this as expected?)
Unfortunately couldn't record on Windows 10 Pro
In short : do we expect to show the message only once per IP address?
Updated•6 years ago
|
Comment 1•6 years ago
|
||
(In reply to Brahmini Nagabandi from comment #0)
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-02-10)
OS : Mac and Windows 10 ProDepends on bug : https://bugzilla.mozilla.org/show_bug.cgi?id=1524021
Observations:
I have tried
Got it
scenario on Mac OS andUse older version
scenario on Windows 10 Pro respectivelyMac OS :
- After
Dark Theme
is enabled viaabout:addons
, New Tab shows the messageThis version of New Tab doesn't support dark mode yet.
That's expected
(As of now
Discoverystream.config
pref value hasTrue
as default value)
- When user clicks on
Got it
button, New Tab doesn't open inDark Mode
That's correct, Click of Got it should continue the discovery stream experience with dark mode disabled
- If the pref has been set to
False
, New Tab still doesn't open inDark Mode
With Discoverystream.config pref set to false, new tab should open in dark mode if dark theme is enabled.
- Tried disabling
Dark Theme
viaabout:addons
to re-test to see message, but message is not displayed (is this expected, not showing the message multiple times to user? or is this caching issue?)
Yes, If user has previously opted-in by clicking Got it, we shouldn't display dark mode message again. Click of Got it should set 'browser.newtabpage.activity-stream.darkModeMessage' to false. If for testing you need to force see message again you can set browser.newtabpage.activity-stream.darkModeMessage to true and the message should show in dark theme when discovery stream pref is true
QA Recording:
https://www.dropbox.com/s/8dqi3xa09aivqs1/QA%20Rec%20%28%3F%3F%29%20-%20Bug%201524021.mp4?dl=0Windows 10 Pro :
- After
Dark Theme
is enabled viaabout:addons
, New Tab shows the messageThis version of New Tab doesn't support dark mode yet.
That's expected
(As of nowDiscoverystream.config
pref value hasTrue
as default value)- When user clicks on
Use older version
button, New Tab opens inDark Mode
That's expected behavior, this triggers opting out of discovery stream flow that set browser.newtabpage.activity-stream.discoverystream.optOut.0 to true
- If the pref has been set to
False
, New Tab still opens inDark Mode
, unable to get rid ofDark Mode
with pref changes, but defaults back to normal only whenDark Theme
isdisabled
viaabout:addons
(is this as expected?)
That's correct once user opt-out of discovery stream experience, user should go back to default activity stream that will open in dark mode. Switching back to normal/default theme should continue default activity stream experience in default theme
Unfortunately couldn't record on Windows 10 Pro
In short : do we expect to show the message only once per IP address?
We should show dark mode message to user until the action buttons Got it or use older version are clicked. If user takes an action we shouldn't show dark mode message again
Reporter | ||
Comment 2•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-02-19)
OS : Mac and Windows 10 Pro
Works as expected.
Closing as verified.
Reporter | ||
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•5 years ago
|
Description
•