Closed
Bug 1527412
Opened 6 years ago
Closed 6 years ago
Some more cleanups in nsChildView.mm
Categories
(Core :: Widget: Cocoa, enhancement, P2)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(4 files)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
This method could only return something non-null in embedding situations,
in which our ChildView was a subview of somebody else's NSView that conforms
to the mozView protocol. Such a situation hasn't existed for about 10 years.
Depends on D19554
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D19555
|
|
Assignee | |
Comment 4•6 years ago
|
||
This was added in bug 476393 in order to work around a problem with the Java plug-in.
We no longer support that plug-in.
The comment also mentions NSTexturedBackgroundWindowMask which we stopped using in bug 1335191.
Depends on D19556
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/fa484096ffd3 Fix mParentView's type (it doesn't necessarily implement the mozView protocol) and tweak a few comments. r=spohl https://hg.mozilla.org/integration/autoland/rev/82aa9a03b71d Remove unused contextMenu method. r=spohl https://hg.mozilla.org/integration/autoland/rev/80265a268c68 Make nsChildView::mView a ChildView*, because that's what it is. r=spohl https://hg.mozilla.org/integration/autoland/rev/b09a49ab3635 Remove swizzling of -[NSView mouseDownCanMoveWindow]. r=spohl
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fa484096ffd3
https://hg.mozilla.org/mozilla-central/rev/82aa9a03b71d
https://hg.mozilla.org/mozilla-central/rev/80265a268c68
https://hg.mozilla.org/mozilla-central/rev/b09a49ab3635
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•