Closed Bug 1527498 Opened 6 years ago Closed 6 years ago

Avoid drawing each picture cache tile separately

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: kvark, Assigned: kvark)

References

Details

Attachments

(2 files, 1 obsolete file)

I noticed that currently when picture caching is used, every 1024x256 tile turns to be a separate draw call with a dedicated texture. This consumes a fair chunk of CPU time, given that we have roughly 100 draw calls in the budget.

Assignee: nobody → dmalyshau
Status: NEW → ASSIGNED

this change reduces the number of draw calls on a new page from 141 to 104.

Attached file WR texture cache code cleanup (deleted) —

This is a preparatory change that can be useful by itself:

  • use match on EntryKind to allow safe expansion
  • avoid code duplication in get()
  • fix some comments
Keywords: leave-open
Attached file Separate picture texture cache (deleted) —

Manage the texture space for picture tiles separately inside the texture cache.

Attachment #9043452 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: leave-open
Resolution: --- → FIXED
Depends on: 1528674
Depends on: 1528820
Target Milestone: --- → mozilla67
No longer depends on: 1528674
Regressions: 1528674
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: