Closed Bug 1527733 Opened 6 years ago Closed 6 years ago

Remove post element added traversal from XULDocument

Categories

(Core :: XUL, enhancement)

Product:
Core
Component:
XUL
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: bdahl, Assigned: bdahl)

References

Details

Attachments

(1 file)

Bug 1527733 - Remove special XUL DOM tree traversal. r=smaug
(deleted), text/x-phabricator-request
Details

Before when we had overlays, AddSubtreeToDocument and AddElementToDocumentPost use to do a lot more. They currently only handle some l10n code could be handled differently.

My plan is move all xul link elements to be <html:link> elements so their binding code gets handled in BindToTree instead. Then nsXULElement to handle the closing of a linkset element.

This clean up will help support some of browser.xhtml work. Eventually, linkset should also go away when we move more xul docs to have an html structure and use the <head> element.

Blocks: top-level-html

Move functionality out of XULDocument::AddElementToDocumentPost:

  1. Convert all XUL link elements into HTML link elements which have
    code to handle when they are added to the DOM.
  2. Move handling of the end of a linkset element into nsXULElement's DoneAddingChildren callback.
  3. Move document direction reset to where the root element is created.
Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/653381afe8bc Remove special XUL DOM tree traversal. r=smaug

https://hg.mozilla.org/mozilla-central/rev/653381afe8bc

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: