This is a Legal blocker to shipping credit card storage (e.g. for credit card autofill or web payments).

This probably needs help from a copywriter still.

We also need to fix the code to honour this pref for the credit card autofill case. Currently it's only honoured for the edit card page.

Cindy, Holly - can I ask for the copy for the UI? I have the code ready using the mock text from the design.

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #3)

Cindy, Holly - can I ask for the copy for the UI? I have the code ready using the mock text from the design.

I've written some copy to accompany the checkbox and it's out for review by the Content Strategy team - will post here when it's been approved.

UX rec: New checkbox should be indented under the credit card checkbox line. String below:

Forms and Autofill  
[   ] Autofill addresses   Learn more   {Saved Addresses…}
[   ] Autofill credit cards  Learn more   {Saved Credit Cards…}
         [   ] Ask for permission (with TouchID or your device’s password) to autofill, view, or edit stored credit cards.

     [   ] Ask for permission (with TouchID or your device’s password) to autofill, view, or edit stored credit cards.

That string seems very macOS-specific. Should we replace "TouchID" with "Windows Hello" on Windows?

I guess for now we need to hide this option on Linux too and anywhere else OSKeyStore.canReauth() returns false (including old macOS)

Good catch! Thank you

New UX rec:
Display logic:
OSKeyStore.canReauth() returns false: Do not display
OSKeyStore.canReauth() returns true: New checkbox should be displayed indented under the credit card checkbox line. Hierarchy & string below:

Forms and Autofill  
[   ] Autofill addresses   Learn more   {Saved Addresses…}
[   ] Autofill credit cards  Learn more   {Saved Credit Cards…}
         [   ] Require [OS type] authentication to autofill, view, or edit stored credit cards.

Strings:
MacOS: Require macOS authentication to autofill, view, or edit stored credit cards.
Windows : Require Windows authentication to autofill, view, or edit stored credit cards.

Passed legal review.

https://hg.mozilla.org/mozilla-central/rev/9f9e8c915af4

Question I've got from a localizer:

• The checkbox label (Require XXX authentication to autofill…) ends up with a period, which seems incorrect for a checkbox.
• The mockup linked in comment 0 has a "Learn more" link after the checkbox, but that's not in the code.

Should the period be removed, or there's a plan to add a link?

That's a question for Holly. The copy was introduced in Comment 7.

Looking into an answer for this (it's dependent on SUMO).

Please keep the period at the end of the sentence and add a "Learn more" link to the end of it (as shown in the comp).
Link url: https://support.mozilla.org/en-US/kb/credit-card-autofill#w_require-authentication-for-autofill

Verified - Fixed on Beta 79.0b7 on MacOS 10.13, Windows 10 and Ubuntu 18.04.
"Require macOS/Windows authentication to autofill, view, or edit stored credit cards." checkbox is displayed.
On latest Nightly 80.0a1 (2020-07-13) the "Learn more" hyperlink is also displayed at the end of the above mentioned string. On Ubuntu 18.04 the checkbox is not displayed.