Closed
Bug 1527946
Opened 6 years ago
Closed 6 years ago
QuantumBar: Input value doesn't update when cycling through results until no result is selected
Categories
(Firefox :: Address Bar, enhancement, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: standard8, Assigned: dao)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Some of the tests in browser_urlbarOneOffs.js are failing because gURLBar.textValue is not the empty string.
This might be intentional, but either way we should fix up the test to match what we want.
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P2
|
Reporter | |
Comment 1•6 years ago
|
||
browser_urlbarOneOffs_searchSuggestions.js may also need fixing due to this.
|
||
Comment 2•6 years ago
|
||
The patch in bug 1528430 fixes this for browser_urlbarOneOffs_searchSuggestions.js but not browser_urlbarOneOffs.js, and I don't know why right now.
|
||
Updated•6 years ago
|
Blocks: quantumbar-release
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Summary: QuantumBar: Work out differences with "textValue" tests failing when cycling through one-off buttons → QuantumBar: Input value doesn't update when cycling through results until no result is selected
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9049260 -
Attachment description: Bug 1527946 - QuantumBar: Input value doesn't update when cycling through results until no result is selected. r=Standard8 → Bug 1527946 - QuantumBar: Update the input value when cycling through results until no result is selected. r=Standard8
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34a3d6b4f10f
QuantumBar: Update the input value when cycling through results until no result is selected. r=Standard8
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.
Description
•